Open Bug 1935622 Opened 2 months ago Updated 2 months ago

Investigate customizing inlining thresholds to improve performance / size tradeoff.

Categories

(Firefox Build System :: General, task)

task

Tracking

(Not tracked)

People

(Reporter: sergesanspaille, Assigned: sergesanspaille)

References

(Blocks 1 open bug)

Details

(Whiteboard: [sp3])

Attachments

(1 file)

Per https://chromium.googlesource.com/chromium/src.git/+/f5361ce9a99a600ec483e2694414d4fb638f1b6a%5E%21/ chrome for Android customizes the inlining threshold, we might want to check if it's valuable to do so for fx too.

I'm generally not a big fan of customizing these values, but let's give it a try on android at least.

Various attempts (android, aarch64):

threshold = 320, sp3: +1.25% , apk size -0.03%, perf link

threshold = 360, sp3:+0.72%, apk size +0.17%, perf link

threshold = 400, sp3: +1.74%, apk size +0.41% perf link

Notes:

  • the apk size variation have been computed based on the size of geckoview_example.apk
  • the default threshold is 315

It's just +20 on the default but it shows a nice sp3 benefit of +1.25%
while basically not affecting the apk size (< 0.05% change).

Whiteboard: [sp3]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: