1935899 - extend about:processes for FreeBSD

Status: RESOLVED FIXED

(Toolkit :: Performance Monitoring, enhancement)

Description

[Christoph Moench-Tegeder]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:133.0) Gecko/20100101 Firefox/133.0

Steps to reproduce:

The current code for about:processes on BSD - toolkit/components/processtools/ProcInfo_bsd.cpp - covers OpenBSD only. This extends the work from bug#1772090 to FreeBSD (the sysctl interface is ever so slightly different)

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Toolkit::Performance Monitoring' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Christoph Moench-Tegeder]

Attachment: Bug 1935899 - Extend BSD about:processes for FreeBSD r=glandium,jld,gerald,gaston

The sysctl interface on FreeBSD is ever so slightly different
from OpenBSD. Especially, we have a different number of elements
in the mib name, so namelen becomes a variable initialised inside
the #ifdef'ed code, and the calculation of the number of processes
in the result differs between OpenBSD and FreeBSD. Lastly, we need
to process the results differently on FreeBSD.

Comment 3

[Christoph Moench-Tegeder]

I have this patch in FreeBSD since nearly 18 months (Firefox 116) now, but I always postponed to submit it.
https://cgit.freebsd.org/ports/commit/www/firefox/files/patch-toolkit_compontents_processtools_procinfo__bsd.c?id=57ca3177d2a513bfd1cd73e6742a35efadc49cd1
We use this patch for both -release and -esr branches.

Comment 4

[Christoph Moench-Tegeder]

[Tracking Requested - why for this release]: Patch is in use for a log time, so tracking upcoming releases 134 and up, and esr128 (patch works there, too). Older releases are affected but not a priority (patched locally), and esr115 is not in use on FreeBSD anymore.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

FreeBSD isn't a Tier 1 platform, so we're not inclined to track bugs which apply only to it. That said, we'll be happy to uplift patches once nominated.

Comment 6

[Christoph Moench-Tegeder]

Hi, could omeone land this? (Phabricater says "ready to land", but I'm - obviously - not permitted to do so myself).

Comment 7

[Florian Quèze [:florian]]

(In reply to Christoph Moench-Tegeder from comment #6)

Hi, could omeone land this? (Phabricater says "ready to land", but I'm - obviously - not permitted to do so myself).

Hello. I left trivial review comments at https://phabricator.services.mozilla.com/D231490#8010391, I assumed you would either address them, or wait for reviews from the other two reviewers (but they might not see the review request as they are not marked as blocking reviewers).

Comment 8

[Christoph Moench-Tegeder]

Attachment: Bug 1935899 - Extend BSD about:processes for FreeBSD r=florian,gaston

The sysctl interface on FreeBSD is ever so slightly different
from OpenBSD. Especially, we have a different number of elements
in the mib name, so namelen becomes a variable initialised inside
the #ifdef'ed code, and the calculation of the number of processes
in the result differs between OpenBSD and FreeBSD. Lastly, we need
to process the results differently on FreeBSD.

Comment 9

[Christoph Moench-Tegeder]

(In reply to Florian Quèze [:florian] from comment #7)

Hello. I left trivial review comments at https://phabricator.services.mozilla.com/D231490#8010391, I assumed you would either address them, or wait for reviews from the other two reviewers (but they might not see the review request as they are not marked as blocking reviewers).

Ah, I misunderstood the interaction between that and "ready to land". Here we go. Thanks!

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bf9237a58dce
Extend BSD about:processes for FreeBSD r=florian,gaston

Comment 11

[amarc]

https://hg.mozilla.org/mozilla-central/rev/bf9237a58dce