1936036 - Replace (deprecated) flag histogram MASTER_PASSWORD_ENABLED with a boolean Scalar

Status: RESOLVED FIXED

(Core :: DOM: Credential Management, task, P1)

Description

[Chris H-C :chutten]

We're finally cleaning up the eight-year-deprecated histogram kind flag in bug 1935160 which means we're looking at (among others) the venerable MASTER_PASSWORD_ENABLED. We still look at its data so we can't just remove it like we'll be doing for some of the others.

The chosen migration path: change it into a Scalar with kind: boolean.

USAGE NOTE: Old clients that never update will forever send us the old histogram data, so if your query wishes to span clients that haven't updated to versions with this change please change instances of

 mozfun.hist.extract(payload.histograms.master_password_enabled).sum > 0 as master_password_enabled,

into

  COALESCE(payload.processes.parent.scalars.master_password_enabled, mozfun.hist.extract(payload.histograms.master_password_enabled).sum > 0) AS master_password_enabled

If your query doesn't need to include clients who haven't updated to versions with this change, you can switch to using Glean instead like so:

SELECT
  metrics.boolean.master_password_enabled
FROM firefox_desktop.metrics AS m
WHERE
  submission_timestamp > TIMESTAMP_SUB(CURRENT_TIMESTAMP(), INTERVAL 7 DAY)

Comment 1

[Chris H-C :chutten]

Attachment: Bug 1936036 - Replace flag histogram MASTER_PASSWORD_ENABLED r?mtigley

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/09309bd0411d
Replace flag histogram MASTER_PASSWORD_ENABLED r=mtigley,firefox-desktop-core-reviewers ,mossop

Comment 3

[amarc]

https://hg.mozilla.org/mozilla-central/rev/09309bd0411d