1936088 - Stop using JSM in the tests for EXTRA_JS_MODULES

Status: RESOLVED FIXED

(Firefox Build System :: General, task)

Description

[Tooru Fujisawa [:arai]]

https://searchfox.org/mozilla-central/source/python/mozbuild/mozbuild/test/backend/data/build/app/moz.build#4

The build backend test is using JSM files for EXTRA_JS_MODULES etc.
They can be done also with ESM.

Comment 1

[Tooru Fujisawa [:arai]]

Attachment: Bug 1936088 - Part 2: Stop using JSM in the tests for the build backend. r?#firefox-build-system-reviewers!

Comment 2

[Tooru Fujisawa [:arai]]

Attachment: Bug 1936088 - Part 1: Output the line annotation in the .mjs files. r?#firefox-build-system-reviewers!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/33cc24a7bbf5
Part 1: Output the line annotation in the .mjs files. r=firefox-build-system-reviewers,glandium
https://hg.mozilla.org/integration/autoland/rev/9146242082da
Part 2: Stop using JSM in the tests for the build backend. r=firefox-build-system-reviewers,glandium

Comment 4

[agoloman]

Backed out for causing build bustages @AppConstants.sys.mjs

• Backout link
• Push with failures
• Failure Log

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aad12cdcbe71
Part 1: Output the line annotation in the .mjs files. r=firefox-build-system-reviewers,glandium
https://hg.mozilla.org/integration/autoland/rev/4bb5c3c36432
Part 2: Stop using JSM in the tests for the build backend. r=firefox-build-system-reviewers,glandium

Comment 6

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/aad12cdcbe71
https://hg.mozilla.org/mozilla-central/rev/4bb5c3c36432

Comment 7

[Mayank Bansal]

FWIW, this bug lead to a 512byte increase in Base content JS opt fission numbers. These numbers are below any alert thresholds.