1936307 - [IAN] Stack patches for ESR uplift

Status: RESOLVED FIXED

(Thunderbird :: General, task)

Description

[Toby Pilling [:tobyp]]

Once Glean has been successfully uplifted, we would like to uplift the stack of in-app notification patches.

Comment 1

[Martin Giger [:freaktechnik]]

Attachment: Bug 1936307 - Squashed in-app notification stages 1 and 2. r=arschmitz,aleca,mkmelin,tobyp

List of bugs or specific changes squashed into this commit:

Bug 1909633 - Updating cached in-app notifications pushes unfiltered list to NotificationManager
Bug 1909668 - Create in-app-notification-close-button custom element
Bug 1918062 - Handle clear event in in-app-notifcation-manager
Bug 1917624 - Handle new notification event from NotificationManager in in-app-notification-manager
Bug 1916948 - Create in-app-notification-manager
Bug 1910944 - Create in-app-notification-container without final style
Bug 1918168 - Create in-app-notification custom element
Bug 1909677 - Create in-app-notification-button custom element
Bug 1918699 - Insert in-app-notification-manager into main window
Bug 1904308 - Implement fetching in-app notifications from server
Bug 1909631 - Rebuild in-app notification candidates list on intl:app-locales-changed
Relevant parts of Bug 1904035 - Add unit tests for LinkHelper. r=aleca
Bug 1918832 - Support donations_old notification type
Bug 1918727 - Style in-app-notification-container and children with the donation styles
Bug 1916951 - Add close button handling for in-app notifications
Bug 1918335 - Only allow https:// URLs for the in-app-notification CTA
Bug 1903230 - Add pref to bypass all filtering for in-app notifications
Bug 1918831 - Adjust rules-based notification selection to use targeting.*.displayed_notifications
Bug 1920725 - Add styles to position in-app-notifications in main window
Bug 1922319 - update in-app-notifications type old_donations to old_donation. r=freaktechnik
Bug 1919278 - Add telemetry to in-app-notifications. r=mkmelin
Bug 1919110 - add focus restoration for in-app-notifications. r=freaktechnik
Bug 1919103 - Add screen reader announcing and keyboard shortcut to in-app-notifications. r=freaktechnik
Bug 1922551 - Enable in-app notifications by default. r=tobyp
Bug 1925666 - Show in app notifications when their start_at time comes. r=aleca
Bug 1931782 - Format in-app notification CTA URLs with the URL formatter. r=arschmitz
Bug 1920551 - Explicitly set jsdoc name to avoid parsing issue. r=rjl
Bug 1928452 - Enable support for new in-app notifications types: blog, donation_tab & donation_browser
Bug 1801529 - Enable valid-jsdoc linter on inappnotifications component. rs=me
Bug 1925656 - Add support for remaining in-app notification types (message + security)
Bug 1931424 - in-app notifications: enable support for new targeting on pref value
Bug 1933302 - Make sure last update of in-app notifications is initialized to a sensible value. r=arschmitz
Bug 1919751 - Only fetch in-app notification updates on initialization if cache is too old. r=mkmelin
Bug 1932019 - Use URL formatting for in app notifications update URL. r=arschmitz
Bug 1934268 - Don't try to fetch empty URL for in app notification update. r=vineet
Bug 1934871 - Fix displayed_notifications filter logic. r=tobyp,arschmitz
Bug 1933286 - Make CTA optional for in-app-notifications. r=freaktechnik
Bug 1934756 - Fix alignment of x close button icon on in-app-notifications. r=freaktechnik
Relevant parts of Bug 1935239 - Port bug 1837658: Enable stylelint linter against use of units for zero lengths
Bug 1933509 - Fix dark mode colors for in app notifications. r=freaktechnik,micahilbery
Bug 1935661 - Reduce space between description and action button in blog, message and security type notifications. r=arschmitz,micahilbery
Bug 1925658 - Support position for in-app-notifications. r=freaktechnik,micahilbery
Bug 1935327 - Add docs for in-app notifications. r=heather,tobyp,arschmitz
Bug 1925660 - Set title on cta for in app notifications. r=freaktechnik
Bug 1935658 - Fix in-app-notification story. r=arschmitz
Bug 1925661 - Use cache-control headers to dictate polling frequency for in-app notifications
Bug 1936323 - Limit amount of notifications and updates per day for in-app notifications. r=freaktechnik
Bug 1934924 - in-app notifications: Adjust URL to include schema version
Bug 1936306 - [IAN] Use progressively longer intervals to re-check for notifications in the case of network failure
Bug 1925665 - Initialize in-app notifications from data shipped with the application. r=tobyp,arschmitz
Bug 1933289 - Load in-app-notification-manager async. r=aleca
Bug 1933294 - Add additional telemetry to in-app-notifications. r=freaktechnik
Bug 1936351 - Update pre-baked IAN data with 2025 schedule. r=freaktechnik,sancus
Relevant parts of Bug 1948245 - Use normal license header instead of one converted from html. r=arschmitz
Bug 1933579 - Fix high contrast mode for in app notifications. r=freaktechnik,micahilbery
Bug 1919759 - Try to fix intermittent comm/mail/components/inappnotifications/test/browser/browser_inAppNotificationButton.js | Test timed out. r=tobyp

Comment 2

[Martin Giger [:freaktechnik]]

Comment on attachment 9474120 [details]
Bug 1936307 - Squashed in-app notification stages 1 and 2. r=arschmitz,aleca,mkmelin,tobyp

Uplift Approval Request

• Please state case for uplift consideration and ensure bug severity is set: In-app notification feature is desired on ESR for better appeal management.
• User impact if declined: We'll be limited to existing (uplift based) appeals system.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Daily?: Yes
• Has the fix been verified in Beta?: Yes
• Needs manual test from QA?: Yes
• If yes, steps to reproduce: Separate instructions provided directly.
• List of other uplifts needed: bug 1954442
• Risk to taking this patch: Medium
• Why is the change risky/not risky? (and alternatives if risky): Big change set, even though mostly contained to this single system.
• String changes made/needed: New ftl file, mail/locales/en-US/messenger/inAppNotifications.ftl

Comment 3

[Corey Bryant]

Comment on attachment 9474120 [details]
Bug 1936307 - Squashed in-app notification stages 1 and 2. r=arschmitz,aleca,mkmelin,tobyp

[Triage Comment]
Approved for esr128
Needs l10n update for string changes.

Comment 4

[Corey Bryant]

Thunderbird 128.9.0esr:
https://hg.mozilla.org/releases/comm-esr128/rev/a59bb574da48

Comment 5

[Martin Giger [:freaktechnik]]

Relnote for beta/release was in bug 1922551