Open Bug 1936561 Opened 2 months ago Updated 3 days ago

Remove FormAutofillContent

Categories

(Toolkit :: Form Autofill, task, P2)

task

Tracking

()

REOPENED

People

(Reporter: dimi, Assigned: dimi)

References

Details

(Whiteboard: [fxcm-backlog])

Attachments

(2 files)

No description provided.
Attachment #9442935 - Attachment description: WIP: Bug 1936561 - Remove FormAutofillContent → Bug 1936561 - Remove per process state from formautofill r=neil
Whiteboard: [fxcm-backlog]
Pushed by dlee@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/fb4a70072b60 Remove per process state from formautofill r=credential-management-reviewers,NeilDeakin
Backout by csabou@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0c4a268be9cb Backed out changeset fb4a70072b60 for causing gv-junit AutocompleteTest related failures. CLOSED TREE

Backed out for causing gv-junit AutocompleteTest related failures

Push with failures

Failure log

Backout link

Flags: needinfo?(dlee)

This change also seems to be causing UI test related failures (Credit card and address autofill)

(In reply to Andrei Jolțan [:Andi] from comment #5)

This change also seems to be causing UI test related failures (Credit card and address autofill)

Additional information, it looks like autofill does not work at all in Fenix with this change based on video in the associated matrix link:

https://console.firebase.google.com/project/moz-fenix/testlab/histories/bh.66b7091e15d53d45/matrices/4651754434285092919/details?stepId=bs.5cb8dd90fe141e04&testCaseId=1&tabId=video

These suites{Fenix/Focus/A-C} can be ran on Try via ./mach try preset --firefox-android and are ran on Android emulator on Firebase Test Lab.

Pushed by dlee@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6c212cefdfbd Remove per process state from formautofill r=credential-management-reviewers,NeilDeakin
Regressions: 1941795

thank you for the info. It seems that there is a different issue, i'll look into it.

Regressions: 1941805
Status: ASSIGNED → RESOLVED
Closed: 29 days ago
Resolution: --- → FIXED
Target Milestone: --- → 136 Branch
Regressions: 1941862
Regressions: 1941860
Regressions: 1941861
Backout by sstanca@mozilla.com: https://hg.mozilla.org/mozilla-central/rev/bf920dd0a5a1 Backed out changeset 6c212cefdfbd as requested by dmeehan for causing multiple test failures. a=backout

This broke the autofill feature. :aaronmt can provide more details if needed but copying some info from a slack thread:

One can save autofill entries in settings, but there is no prompt to use the entries on forms. Seen in our tests.

Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Target Milestone: 136 Branch → ---

On Fenix, on attempt to autofill a saved credit card there's supposed to be detection via a visible UI header for the user to interact with to use a saved card that is missing. Similarly, a "Select Address" header for a saved autofill form address entry. The detection seems intermittent with this change. Attaching a screenshot of aforementioned header from Fenix builds unaffected. Tests expect the presence of these headers to interact with which are not finding it and thus failing.

mozac_feature_prompts_credit_card_select_prompt.xml and mozac_feature_prompts_address_select_prompt.xml

https://searchfox.org/mozilla-central/source/mobile/android/android-components/components/feature/prompts/src/main/java/mozilla/components/feature/prompts/address/AddressSelectBar.kt

https://searchfox.org/mozilla-central/source/mobile/android/android-components/components/feature/prompts/src/main/java/mozilla/components/feature/prompts/creditcard/CreditCardSelectBar.kt

Flags: needinfo?(dlee)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: