Closed
Bug 1936575
Opened 2 months ago
Closed 23 days ago
set to default prompt should not be displayed until the ToS card has been accepted
Categories
(Fenix :: Onboarding, defect, P1)
Tracking
(firefox136 fixed)
RESOLVED
FIXED
136 Branch
Tracking | Status | |
---|---|---|
firefox136 | --- | fixed |
People
(Reporter: towhite, Assigned: mavduevskiy)
References
Details
Attachments
(3 files)
No description provided.
Assignee | ||
Updated•28 days ago
|
Assignee: towhite → mavduevskiy
Assignee | ||
Comment 1•27 days ago
|
||
There is an opportunity to simplify the prompt flag logic and reuse it in deciding if an onboarding card should fire the prompt (we want to make exceptions for certain cards). It also fixes the edge case of bug 1936654, when switching from a different from theme to default (let's say, the default is dark and we are switching from manual light to default dark), the propt is shown repeatedly.
Assignee | ||
Comment 2•27 days ago
|
||
Moving firing logic of the prompt out of the fragment lifecycle; when a card gets displayed, evaluating if the propt should be fired.
Assignee | ||
Comment 3•26 days ago
|
||
Existing implementation was difficult to test, being part of the fragment.
Updated•24 days ago
|
Attachment #9446733 -
Attachment description: WIP: Bug 1936575 - PART 1: refactor prompt flag → Bug 1936575 - PART 1: refactor prompt flag
Updated•24 days ago
|
Attachment #9446734 -
Attachment description: WIP: Bug 1936575 - PART 2: Do not trigger default browser prompt until ToS is accepted → Bug 1936575 - PART 2: Do not trigger default browser prompt until ToS is accepted
Updated•24 days ago
|
Attachment #9458978 -
Attachment description: WIP: Bug 1936575 - PART 3: Refactoring and adding tests to the default browser propmt logic → Bug 1936575 - PART 3: Refactoring and adding tests to the default browser propmt logic
Assignee | ||
Updated•24 days ago
|
Summary: Prevent set to default prompt being re-displayed each time a card is shown → set to default prompt should not be displayed until the ToS card has been accepted
Pushed by icedicedcoffee@proton.me:
https://hg.mozilla.org/integration/autoland/rev/efb5e9d683ee
PART 1: refactor prompt flag r=android-reviewers,twhite
https://hg.mozilla.org/integration/autoland/rev/6b0b18434da4
PART 2: Do not trigger default browser prompt until ToS is accepted r=android-reviewers,twhite
Comment 5•23 days ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/efb5e9d683ee
https://hg.mozilla.org/mozilla-central/rev/6b0b18434da4
Status: NEW → RESOLVED
Closed: 23 days ago
status-firefox136:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 136 Branch
Pushed by mavduevskiy@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/933c195b2aca
PART 3: Refactoring and adding tests to the default browser propmt logic r=android-reviewers,gmalekpour,twhite
Comment 7•20 days ago
|
||
bugherder |
You need to log in
before you can comment on or make changes to this bug.
Description
•