Closed Bug 1936670 Opened 2 months ago Closed 16 days ago

Delete profile page - Audit and fix a11y properties

Categories

(Toolkit :: Startup and Profile System, defect, P2)

defect

Tracking

()

RESOLVED FIXED
136 Branch
Tracking Status
firefox136 --- fixed

People

(Reporter: jhirsch, Assigned: niklas)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [fidefe-profile-management])

Attachments

(4 files)

Audit and fix: focus order, tab order, roles, and labels as spec'd for the delete profile page.

Figma annotations extracted to a screenshot and copied out here for reference:



Entry types for the list below:

Type: Presentational
(Mobile and Desktop) Used for decorative elements that should be ignored by screen readers.

Type: Note
(Mobile) Used for all annotations
(Desktop) Used for non-interactive components and landmarks

Type: Arrow key navigation
(Desktop only) For interactive elements that can be reached by using the arrow keys (usually within a component reached through the tab key)

Type: Tab navigation
(Desktop only) For interactive elements that can be reached by using the tab-key.


Focus order:

  1. Avatar image
  • Type: Note
  • Name: "${avatar_name} icon"
  • Role: graphic
  1. Page title
  • Type: Note
  • Name: [use on-screen string]
  • Role: Heading 1
  1. Page subtitle
  • Type: Note
  • Name: [use on-screen string]
  • Role: paragraph
  1. List of data definitions for the profile
  • Type: Note
  • Name: Group
  • Role: Descriptive list
  • Note: This should read name and count from top down

For each of the following items, the properties should be:

  • Type: Note
  • Name: [use on-screen string, for example "Open windows" or "Open tabs"]
  • Role: Definition term

And for each row, there should be a corresponding item for its value:

  • Type: Note
  • Name: [use on-screen string, which in general will be a number, like the number of open windows]
  • Role: Definition description

Finally, we have the two buttons at the bottom of the page, which participate in the tab navigation order:

  1. Cancel button
  • Type: tab navigation
  • Name: Cancel
  • Role: Button
  • Note: Takes user back to whatever page they came from
  1. Delete button
  • Type: tab navigation
  • Name: Delete
  • Role: Button
  • Note: Closes all windows for the current profile and exits Firefox, then deletes the profile as a background task after exiting.

Mass setting S2 severity for 0.5% release bugs. Apologies for the bug spam!

Severity: -- → S2
Priority: -- → P2
Assignee: nobody → nbaumgardner
Status: NEW → ASSIGNED
Pushed by nbaumgardner@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2ea01df302ea Add alt text to profile avatars. r=profiles-reviewers,fluent-reviewers,jhirsch,flod
Status: ASSIGNED → RESOLVED
Closed: 16 days ago
Resolution: --- → FIXED
Target Milestone: --- → 136 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: