1936752 - Unable to collapse the Tab Group after closing other tabs

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect, P2)

Description

[Gabi Cheta [:Gabi] Desktop QA]

Attachment: 2024-12-12_10h35_02.gif

Affected versions

• Firefox Nightly 135.0a1 build 20241211100250

Affected platforms

• Windows 10 x64, macOS 14

Untested platform

• Ubuntu

Preconditions

• Set browser.tabs.groups.enabled true

Steps to reproduce

1. Open a few tabs
2. Create a Tab Group
3. Close the other free tabs
4. Collapse the Tab Group

Expected result

• Tab Group is collapsed

Actual result

• Unable to collapse the Tab Group after closing the other tabs,
• Once a default new tab is loaded in the tab strip since there are no new tabs opened, the Tab Group can't be collapsed

Regression range

• New feature

Additional notes

• See attached gif for more details
• Issue is easier to reproduce by collapsing/expanding the Tab Group after opening a new tab and closing the new tab created by default

Comment 1

[Dão Gottwald [:dao]]

I can't reproduce this. Do you still see this in the current Nightly? Are there perhaps additional steps that need to be taken to end up in this state?

Comment 2

[Sören Hentzschel]

I've had the same problem a few times, but I was unfortunately not able to find steps to reproduce. Since the problem is difficult to reproduce, I cannot say whether the current nightly version is still affected. I'm also not sure when exactly the problem last occurred, but it was definitely a few days ago.

Comment 3

[Gabi Cheta [:Gabi] Desktop QA]

Attachment: 2024-12-16_16h16_55.gif

Comment 4

[Gabi Cheta [:Gabi] Desktop QA]

(In reply to Dão Gottwald [:dao] from comment #1)

I can't reproduce this. Do you still see this in the current Nightly? Are there perhaps additional steps that need to be taken to end up in this state?

Issue is reproducible on the latest Firefox Nightly 135.0a1(20241216093645), tested on a Windows 10 x64.
I'm attaching a new recording of the issue with all the steps I've taken from profile creation, the issue seems to occur the moment a new tab is created when trying to collapse the Tab Group.

Comment 5

[Dão Gottwald [:dao]]

Attachment: Collapse.mp4

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:jswinarton, could you have a look please?

For more information, please visit BugBot documentation.

Comment 7

[Stephen Thompson [:sthompson]]

Attachment: Bug 1936752 - unlock tab sizes in collapsed tab groups r=dao,dwalker,jswinarton

In certain cases when closing a tab(s), we temporarily lock the width of the tabs instead of letting them grow/shrink. If you close a tab and then quickly collapse a tab group right afterwards, you can end up with the tab group label going into the collapsed state correctly but the tabs in the tab group are still visible.

The issue is that we lock tab sizes on visible tabs using max-width: ... !important and we are hiding tabs in collapsed tab groups by using a CSS rule of max-width: 0. When we unlock the tab sizes, we only unlock visible tabs, but the tabs inside of the collapsed tab group are no longer considered visible.

This fix removes the tab lock size max-width: ... !important rule on all tabs regardless of tab visibility.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c16f0c7ecb89
unlock tab sizes in collapsed tab groups r=jswinarton,tabbrowser-reviewers

Comment 9

[agoloman]

https://hg.mozilla.org/mozilla-central/rev/c16f0c7ecb89

Comment 11

[Timea Zsoldos [:zstimi/tzsoldos], Desktop QA]

I have reproduced this issue using Firefox 135.0a1 (2024.12.16) on Windows 10.
I can confirm this issue is fixed, I verified using Firefox 136.0a1 on Windows 10, Ubuntu 22 and on macOS 12.