Closed Bug 1936762 Opened 2 months ago Closed 2 months ago

ContextualIdentityService should check if a file exists before attempting to read from it

Categories

(Core :: DOM: Security, defect, P2)

defect

Tracking

()

RESOLVED FIXED
135 Branch
Tracking Status
firefox135 --- fixed

People

(Reporter: janv, Assigned: janv)

References

Details

Attachments

(1 file)

https://phabricator.services.mozilla.com/D231265 was backed out because it needs to call ContextualIdentityService.getPrivateIdentity some time after startup. The failing test is browser/components/tests/marionette/test_no_errors_clean_profile.py.

The issue is that ContextualIdentityService doesn't check if containers.json exists before reading from it, which results in an error. Although the error is caught, it still triggers a warning in the console, which the test detects.

Summary: ContextualIdentityService should check if a file exists before attempting to read from it. → ContextualIdentityService should check if a file exists before attempting to read from it

The ContextualIdentityService was attempting to read the containers.json file
without verifying its existence. This caused warnings to appear in the console
when the file was missing.

Pushed by jvarga@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/84389aa6b914 ContextualIdentityService should check if a file exists before attempting to read from it; r=baku
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → 135 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: