Closed
Bug 1937017
Opened 2 months ago
Closed 25 days ago
Prevent applyThemeIfRequired being on every composition in ThemeOnboardingPage
Categories
(Fenix :: Onboarding, task, P1)
Tracking
(firefox136 fixed)
RESOLVED
FIXED
136 Branch
Tracking | Status | |
---|---|---|
firefox136 | --- | fixed |
People
(Reporter: towhite, Assigned: Gela)
References
Details
(Whiteboard: [fxdroid][group2])
Attachments
(1 file, 1 obsolete file)
No description provided.
Summary: Prevent applyThemeIfRequired on every composition in ThemeOnboardingPage → Prevent applyThemeIfRequired being on every composition in ThemeOnboardingPage
Whiteboard: [fxdroid][group2]
Updated•2 months ago
|
Pushed by gmalekpour@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/62aad4517838
Move the theme application logic to OnboardingStore r=android-reviewers,tjorjani
Status: NEW → RESOLVED
Closed: 25 days ago
status-firefox136:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 136 Branch
Original Revision: https://phabricator.services.mozilla.com/D232679
Updated•23 days ago
|
Attachment #9459690 -
Flags: approval-mozilla-beta?
Comment 5•23 days ago
|
||
beta Uplift Approval Request
- User impact if declined: Theme application logic gets called more than needed which can impact performance
- Code covered by automated testing: no
- Fix verified in Nightly: yes
- Needs manual QE test: no
- Steps to reproduce for manual QE testing: n/a. Not really possible to test in QA or via automated tests as this is a technical improvement
- Risk associated with taking this patch: very low
- Explanation of risk level: Move the call to Onboardingstore to avoid it being instantiated when not needed
- String changes made/needed: n/a
- Is Android affected?: yes
Comment 6•22 days ago
|
||
Comment on attachment 9459690 [details]
Bug 1937017 - Move the theme application logic to OnboardingStore
This needs a rebased patch for Beta uplift if that's still desired.
Flags: needinfo?(gmalekpour)
Attachment #9459690 -
Flags: approval-mozilla-beta? → approval-mozilla-beta-
Since it's not needed for the feature to work, we can hold off on uplifting this and let it ride the normal train.
Flags: needinfo?(gmalekpour)
Updated•22 days ago
|
Attachment #9459690 -
Attachment is obsolete: true
You need to log in
before you can comment on or make changes to this bug.
Description
•