1937772 - The items from the "Create New Tab Group" and "Manage Tab group" panels do not change their state when hovered over or clicked with High Contrast enabled

Status: VERIFIED FIXED

(Firefox :: Tabbed Browser, defect, P2)

Description

[Rares Doghi, Desktop QA]

Attachment: hcm.mp4

Found in

• 135.0a1 (2024-12-17)

Affected versions

• 135.0a1 (2024-12-17)

Preconditions
Set browser.tabs.groups.enabled true
Enable High Contrast

Affected platforms

• all

Steps to reproduce

1. Have a Tab Group created.
2. Right Click the Tab group.
3. Hover over each option from the Tab group Panel
4. Right Click a Tab and Add it to a New Group.
5. Hover over each option from the Create New Tab Group panel.

Expected result

• Each option should change their state when the user hovers over it or Clicks it.

Actual result

• There is no indication that the user is actually on the options from the Tab group panel or which one he is actually clicking.

Regression range
Not a Regression.

Comment 1

[Dão Gottwald [:dao]]

Has bug 1932549 improved or fixed this?

Comment 2

[Rares Doghi, Desktop QA]

Attachment: 2025-01-13_11h57_40.mp4

This was improved a bit by that Bug but the Delete Group button still does not change its state, Please take a look at the screen recording.
Also I think it should also change their state on Click not just when we hover over them.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

The severity field for this bug is set to S3. However, the accessibility severity is higher, .
:mak, could you consider increasing the severity?

For more information, please visit BugBot documentation.

Comment 4

[Dão Gottwald [:dao]]

Reducing the a11y severity given comment 2.

Comment 5

[Dão Gottwald [:dao]]

Attachment: Bug 1937772 - Stop using error color in high contrast mode. r=jswinarton,dwalker

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8d0b8d10757a
Stop using error color in high contrast mode. r=jswinarton,tabbrowser-reviewers

Comment 7

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/8d0b8d10757a

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:dao, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox135 to wontfix.

For more information, please visit BugBot documentation.

Comment 9

[Rares Doghi, Desktop QA]

This issue is verified as fixed in our latest Nightly build 136.0a1 (2025-01-23) however the options still do not change their state on Click, not sure if they should or not.

Comment 10

[Rares Doghi, Desktop QA]

Updating the main status flag.

Comment 11

[Morgan Reschenberg [:morgan]]

(In reply to Rares Doghi, Desktop QA from comment #9)

This issue is verified as fixed in our latest Nightly build 136.0a1 (2025-01-23) however the options still do not change their state on Click, not sure if they should or not.

These menus should follow styling for HCM menus here I've added examples with hovered and clicked menu items. Clicked items should use active state styling. See attached image.

Comment 12

[Morgan Reschenberg [:morgan]]

Attachment: intended menu styling hover vs. clicked (active)

Comment 13

[Rares Doghi, Desktop QA]

Hi @Morgan, are those screenshots from Windows 11 ? should Windows 10 look the same ? I will attach a screen recording for how it looks on windows 10 please take a look.

Comment 14

[Rares Doghi, Desktop QA]

Attachment: HC.mp4

Comment 15

[Morgan Reschenberg [:morgan]]

Attachment: windows 10 HCM black styling

Comment 16

[Morgan Reschenberg [:morgan]]

(In reply to Rares Doghi, Desktop QA from comment #13)

Hi @Morgan, are those screenshots from Windows 11 ? should Windows 10 look the same ? I will attach a screen recording for how it looks on windows 10 please take a look.

I've added an additional screen shot with windows 10 HCM 'black' theme styling. It looks like the styles presented in the screen recording are incorrect.

Comment 17

[Rares Doghi, Desktop QA]

Added Bug 1946020 for the remaining issue. Thanks @Morgan