193797 - <select> accessibility cleanup

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Aaron Leventhal]

This bug is for cleaning up accessibility API support of comboboxes and listboxes

1. Remove the extra ROLE_WINDOW object for simplification. This comes at the
request of a screen reader vendor.
2. Fix the states. The ROLE_LIST object wasn't initializing it's state properly,
and was getting random garbage in it.
3. Remove extra files and inheritence that we don't need

It's a large patch, but it mostly just moves code around.

Comment 1

[Aaron Leventhal]

Attachment: Sorry for the long patch -- mostly moves code around, but also gets rid of ROLE_WINDOW objects

Comment 2

[Aaron Leventhal]

Kyle, this has been tested, and is ready for your review.

Comment 3

[Kyle Yuan]

Comment on attachment 114747 [details] [diff] [review]
Sorry for the long patch -- mostly moves code around, but also gets rid of ROLE_WINDOW objects

r=kyle
two indent problems, maybe caused by accidental usages of TAB?

one is in the first comment in nsHTMLSelectAccessible.cpp

+  *  Listbox:
+  *	    - nsHTMLSelectListAccessible

another is in cstr of nsHTMLSelectOptionAccessible,

Comment 4

[Henry Jia]

Comment on attachment 114747 [details] [diff] [review]
Sorry for the long patch -- mostly moves code around, but also gets rid of ROLE_WINDOW objects

sr=Henry

Pls pay attention to the indent when checking in.

Comment 5

[Aaron Leventhal]

checked in

Comment 6

[Firefox Bug Husbandry Bot]

https://bugzilla.mozilla.org/show_bug.cgi?id=1527381