`mach vendor rust` on Windows modifies files unexpectedly
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
People
(Reporter: btsoi, Unassigned)
References
(Blocks 1 open bug)
Details
On Windows machine on central (07e0c7a4f7fec85d64bfbb81695951c2eee86c9a), I ran .\mach vendor rust
, and the following files were modified.
third_party/rust/libz-rs-sys/.cargo-checksum.json
third_party/rust/libz-rs-sys/Cargo.toml
third_party/rust/libz-rs-sys/LICENSE
third_party/rust/neqo-bin/.cargo-checksum.json
third_party/rust/neqo-bin/Cargo.toml
third_party/rust/neqo-common/.cargo-checksum.json
third_party/rust/neqo-common/Cargo.toml
third_party/rust/neqo-crypto/.cargo-checksum.json
third_party/rust/neqo-crypto/Cargo.toml
third_party/rust/neqo-http3/.cargo-checksum.json
third_party/rust/neqo-http3/Cargo.toml
third_party/rust/neqo-qpack/.cargo-checksum.json
third_party/rust/neqo-qpack/Cargo.toml
third_party/rust/neqo-transport/.cargo-checksum.json
third_party/rust/neqo-transport/Cargo.toml
third_party/rust/neqo-udp/.cargo-checksum.json
third_party/rust/neqo-udp/Cargo.toml
third_party/rust/wgpu-core/.cargo-checksum.json
third_party/rust/wgpu-core/LICENSE.APACHE
third_party/rust/wgpu-core/LICENSE.MIT
third_party/rust/wgpu-hal/.cargo-checksum.json
third_party/rust/wgpu-hal/LICENSE.APACHE
third_party/rust/wgpu-hal/LICENSE.MIT
third_party/rust/wgpu-types/.cargo-checksum.json
third_party/rust/wgpu-types/LICENSE.APACHE
third_party/rust/wgpu-types/LICENSE.MIT
third_party/rust/zlib-rs/.cargo-checksum.json
third_party/rust/zlib-rs/LICENSE
Expected Behavior:
No files should be modified.
Similar issues existed in the past. In the Including Rust Code in Firefox of Firefox source docs,
If you add a dependency on a new crate you must run mach vendor rust to vendor the dependencies into that directory. (Note that mach vendor rust may not work as well on Windows as on other platforms.)
The page provides a link to Bug 1647582, but it is marked resolved. The current behaviour is similar to what is described in this comment.
Reporter | ||
Comment 1•2 months ago
|
||
All the modifications made are similar, as an example here are the git diffs for third_party/rust/libz-rs-sys/.cargo-checksum.json
, third_party/rust/libz-rs-sys/Cargo.toml
and third_party/rust/libz-rs-sys/LICENSE
.
diff --git a/third_party/rust/libz-rs-sys/.cargo-checksum.json b/third_party/rust/libz-rs-sys/.cargo-checksum.json
index 8aea0e2cd571e..4833698781a50 100644
--- a/third_party/rust/libz-rs-sys/.cargo-checksum.json
+++ b/third_party/rust/libz-rs-sys/.cargo-checksum.json
@@ -1 +1 @@
-{"files":{"Cargo.toml":"ed61f3a3f593d664d66d6b71e26b19c1f99654296d0f0918f916c1caa8113f8e","LICENSE":"7d60612df8fcd9d3714871a95b4d3012563246fdea8f6710b7567f83cfa3c8ef","README.md":"46f48b56018d0efef5738be7d930019631899dede51ee5e92f44bd53f6e26749","src/lib.rs":"44e21c7ccacbf35f483ab9d777802624a0d111d161cfd2778a37aa5f33279c47"},"package":null}
\ No newline at end of file
+{"files":{"Cargo.toml":"8097e81a3dd12d19acda67857f4ffe822c4383d79e2f4d500dfc1ea0346d59ea","LICENSE":"1e881ecf2862d01e6e5bc2b861e46886d2a6fb01499c0c508a209a7271b13cf2","README.md":"46f48b56018d0efef5738be7d930019631899dede51ee5e92f44bd53f6e26749","src/lib.rs":"44e21c7ccacbf35f483ab9d777802624a0d111d161cfd2778a37aa5f33279c47"},"package":null}
\ No newline at end of file
diff --git a/third_party/rust/libz-rs-sys/Cargo.toml b/third_party/rust/libz-rs-sys/Cargo.toml
index 1d85590986bc0..92cf683d76c06 100644
--- a/third_party/rust/libz-rs-sys/Cargo.toml
+++ b/third_party/rust/libz-rs-sys/Cargo.toml
@@ -33,7 +33,7 @@ path = "src/lib.rs"
[dependencies.zlib-rs]
version = "0.2.1"
-path = "../zlib-rs"
+path = '..\zlib-rs'
default-features = false
[features]
diff --git a/third_party/rust/libz-rs-sys/LICENSE b/third_party/rust/libz-rs-sys/LICENSE
index 8079b948a62e8..ea5b60640b01f 100644
--- a/third_party/rust/libz-rs-sys/LICENSE
+++ b/third_party/rust/libz-rs-sys/LICENSE
@@ -1,19 +1 @@
-(C) 2024 Internet Security Research Group
-
-This software is provided 'as-is', without any express or implied
-warranty. In no event will the authors be held liable for any damages
-arising from the use of this software.
-
-Permission is granted to anyone to use this software for any purpose,
-including commercial applications, and to alter it and redistribute it
-freely, subject to the following restrictions:
-
-1. The origin of this software must not be misrepresented; you must not
- claim that you wrote the original software. If you use this software
- in a product, an acknowledgment in the product documentation would be
- appreciated but is not required.
-
-2. Altered source versions must be plainly marked as such, and must not be
- misrepresented as being the original software.
-2. Altered source versions must be plainly marked as such, and must not be
- misrepresented as being the original software.
-
-3. This notice may not be removed or altered from any source distribution.
+../LICENSE
\ No newline at end of file
Comment 2•2 months ago
|
||
Description
•