Closed Bug 1938252 Opened 2 months ago Closed 1 month ago

[wpt-sync] Sync PR 49770 - Make UpdateLabel work when there is a label attribute.

Categories

(Core :: DOM: Core & HTML, task, P4)

task

Tracking

()

RESOLVED FIXED
136 Branch
Tracking Status
firefox136 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 49770 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/49770
Details from upstream follow.

David Baron <dbaron@chromium.org> wrote:

Make UpdateLabel work when there is a label attribute.

The code in HTMLOptionElement::UpdateLabel was inconsistent with the
code in SetTextOnlyRendering that does text-only rendering when there is
a label attribute. This applies the one-line fix (although it might be
worth considering future refactoring here).

This was just something I noticed while looking at the code in order to
investigate issue 353764798.

Bug: 353764798
Change-Id: Id948098e9a507a580f73a28885bd99b703e7318a

Reviewed-on: https://chromium-review.googlesource.com/6103332
WPT-Export-Revision: 1e5288a375aed7141398dddc4aeeb0992f348f55

Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests

Status Summary

Firefox

Chrome

FAIL : 1

Safari

TIMEOUT: 1

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

Tests Disabled in Gecko Infrastructure

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/cbb401ab1ff3 [wpt PR 49770] - Make UpdateLabel work when there is a label attribute., a=testonly
Status: NEW → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → 136 Branch
You need to log in before you can comment on or make changes to this bug.