"Sync" should be explained in comments to avoid confusion in localization
Categories
(Firefox for iOS :: General, defect)
Tracking
()
People
(Reporter: delphine, Unassigned, NeedInfo)
Details
Shouldn't "Sync" here be lowercase as the Sync brand is no more?
Bookmarks.EmptyState.Root.ButtonTitle.v135
CC Emilyw for visibility and consistence across products.
Comment 1•2 months ago
|
||
Yes, sync should be in lower case unless it is in a part of the app that requires title case, such as the app menu. Where are you seeing the string capitalized?
Reporter | ||
Comment 2•2 months ago
|
||
@Emily: this is the string in question, with its corresponding comment below: https://github.com/mozilla-mobile/firefox-ios/blob/fb7c2a2986174c3fdeecac9ee0f2137d9177d4ac/firefox-ios/Shared/Strings.swift#L202
Comment 3•2 months ago
|
||
(In reply to Delphine Lebédel [:delphine - Use needinfo] from comment #2)
@Emily: this is the string in question, with its corresponding comment below: https://github.com/mozilla-mobile/firefox-ios/blob/fb7c2a2986174c3fdeecac9ee0f2137d9177d4ac/firefox-ios/Shared/Strings.swift#L202
The string in question is a button, and on iOS buttons are in title case. So this string is correct.
Reporter | ||
Comment 4•1 month ago
|
||
Thanks for confirming Emily.
We should call out in comments that this is a verb and that it's a title case here because it's a button - to avoid any confusion
Reporter | ||
Updated•1 month ago
|
Comment 5•1 month ago
|
||
The severity field is not set for this bug.
:jeevans, could you have a look please?
For more information, please visit BugBot documentation.
Reporter | ||
Comment 6•22 days ago
|
||
This has been fixed. Closing.
Description
•