Closed Bug 1938670 Opened 2 months ago Closed 22 days ago

"Sync" should be explained in comments to avoid confusion in localization

Categories

(Firefox for iOS :: General, defect)

Other
iOS
defect

Tracking

()

RESOLVED FIXED

People

(Reporter: delphine, Unassigned, NeedInfo)

Details

Shouldn't "Sync" here be lowercase as the Sync brand is no more?
Bookmarks.EmptyState.Root.ButtonTitle.v135

CC Emilyw for visibility and consistence across products.

Flags: needinfo?(ewachowiak)

Yes, sync should be in lower case unless it is in a part of the app that requires title case, such as the app menu. Where are you seeing the string capitalized?

Flags: needinfo?(ewachowiak)
Flags: needinfo?(ewachowiak)

(In reply to Delphine Lebédel [:delphine - Use needinfo] from comment #2)

@Emily: this is the string in question, with its corresponding comment below: https://github.com/mozilla-mobile/firefox-ios/blob/fb7c2a2986174c3fdeecac9ee0f2137d9177d4ac/firefox-ios/Shared/Strings.swift#L202

The string in question is a button, and on iOS buttons are in title case. So this string is correct.

Flags: needinfo?(ewachowiak)

Thanks for confirming Emily.
We should call out in comments that this is a verb and that it's a title case here because it's a button - to avoid any confusion

Summary: " Sync" should be lowercase in strings → "Sync" should be explained in comments to avoid confusion in localization

The severity field is not set for this bug.
:jeevans, could you have a look please?

For more information, please visit BugBot documentation.

Flags: needinfo?(jeevans)

This has been fixed. Closing.

Status: NEW → RESOLVED
Closed: 22 days ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.