Closed
Bug 1938994
Opened 2 months ago
Closed 19 days ago
Add document and tests with subscript loader + framescript environment
Categories
(Core :: JavaScript Engine, task, P3)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
136 Branch
Tracking | Status | |
---|---|---|
firefox136 | --- | fixed |
People
(Reporter: arai, Assigned: arai)
References
(Blocks 2 open bugs)
Details
Attachments
(2 files)
EnvironmentObject.h
contains a document about the various environment chain, but it lacks a document for "subscript inside frame script" environment, which has some special handling.
* B.1 Subscript loading into a target object
It's nice to add the document and testcases.
Assignee | ||
Comment 1•1 month ago
|
||
Assignee | ||
Comment 2•1 month ago
|
||
Updated•1 month ago
|
Severity: -- → N/A
Priority: -- → P3
Updated•1 month ago
|
Blocks: sm-runtime
Pushed by arai_a@mac.com:
https://hg.mozilla.org/integration/autoland/rev/bad718f76651
Part 1: Reorder EnvironmentObject document to make the Subscript loading appears after Frame scripts. r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/24440318da2d
Part 2: Add document and tests for subscript in framescript. r=mgaudet
Backed out for causing xpcshell failures @ test_envChain_subscript_in_frameScript.js
- Backout link
- Push with failures
- Failure Log
- Failure line:
TEST-UNEXPECTED-FAIL | js/xpconnect/tests/unit/test_envChain_subscript_in_frameScript.js | xpcshell return code: 0
Flags: needinfo?(arai.unmht)
Assignee | ||
Updated•20 days ago
|
Flags: needinfo?(arai.unmht)
Assignee | ||
Comment 5•20 days ago
|
||
There's some weirdness in the test environment in the android xpcshell. I'll check if it's caused by other tests.
Pushed by arai_a@mac.com:
https://hg.mozilla.org/integration/autoland/rev/df3ed1aaee0d
Part 1: Reorder EnvironmentObject document to make the Subscript loading appears after Frame scripts. r=mgaudet
https://hg.mozilla.org/integration/autoland/rev/365e8b16e802
Part 2: Add document and tests for subscript in framescript. r=mgaudet
https://hg.mozilla.org/mozilla-central/rev/df3ed1aaee0d
https://hg.mozilla.org/mozilla-central/rev/365e8b16e802
Status: ASSIGNED → RESOLVED
Closed: 19 days ago
status-firefox136:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 136 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•