Make `WSRunScanner::TextFragmentData` free from editing host
Categories
(Core :: DOM: Editor, task)
Tracking
()
Tracking | Status | |
---|---|---|
firefox136 | --- | fixed |
People
(Reporter: masayuki, Assigned: masayuki)
References
(Regressed 1 open bug)
Details
Attachments
(6 files)
48 bytes,
text/x-phabricator-request
|
Details | Review | |
Bug 1939220 - part 2: Split `WSRunScanner.cpp` to define the methods of the nested classes r=m_kato!
48 bytes,
text/x-phabricator-request
|
Details | Review | |
Bug 1939220 - part 3: Make `TextFragmentData::BoundaryData` not depend on the editing host r=m_kato!
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
Details | Review |
Assignee | ||
Comment 1•1 month ago
|
||
Depends on D232892
Assignee | ||
Comment 2•1 month ago
|
||
Depends on D232932
Assignee | ||
Comment 3•1 month ago
|
||
Its role is scanning the DOM. Therefore, it can know which node is an editing
host during a scan. Therefore, it does not require the editing host parameter.
To fix that, some utility methods of HTMLEditUtils
needs to work with
non-editable nodes. Therefore, this patch also updates HTMLEditUtils
.
Finally, this gets rid of the NS_ASSERTION
s in the constructor of
TextFragmentData
because it'll be available with non-editable nodes too.
Although current all callers assume that it works as in an editing host.
Depends on D232933
Assignee | ||
Comment 4•1 month ago
|
||
Depends on D232934
Assignee | ||
Comment 5•1 month ago
|
||
Depends on D232935
Assignee | ||
Comment 6•1 month ago
|
||
It stores the editing host. However, its role is scan the DOM from a point in
a block containing the point. Therefore, it can know which node is editing
host when it scans without computing the editing host. So, it does not need
to be specified the editing host.
Then, it can scan non-editable DOM too. Therefore, this extends some utility
methods of HTMLEditUtils
which are used by TextFragmentData
and
BoundaryData
.
Depends on D232936
Comment 8•18 days ago
|
||
Backed out for causing build bustages
Backout link: https://hg.mozilla.org/integration/autoland/rev/bd273dd2220297edf06b3cd483921d2f40430c4a
Assignee | ||
Comment 9•17 days ago
|
||
Hmm, I guess that it's caused by a failure of rebasing. Sorry for that.
Comment 10•17 days ago
|
||
Comment 11•17 days ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/e8e0c9b25e80
https://hg.mozilla.org/mozilla-central/rev/aa3801613a81
https://hg.mozilla.org/mozilla-central/rev/71063939b39c
https://hg.mozilla.org/mozilla-central/rev/11a706f516c2
https://hg.mozilla.org/mozilla-central/rev/afcb603e87d0
https://hg.mozilla.org/mozilla-central/rev/00f73b8c51ab
Description
•