[Experiment] Themes should not be saved when choosing to skip the card
Categories
(Fenix :: Onboarding, defect)
Tracking
(firefox133 unaffected, firefox134 unaffected, firefox135 verified, firefox136 verified)
Tracking | Status | |
---|---|---|
firefox133 | --- | unaffected |
firefox134 | --- | unaffected |
firefox135 | --- | verified |
firefox136 | --- | verified |
People
(Reporter: cmuresan, Assigned: rebecatudor273)
References
(Blocks 1 open bug)
Details
(Whiteboard: [fxdroid][group2])
Attachments
(2 files, 1 obsolete file)
384.93 KB,
video/mp4
|
Details | |
48 bytes,
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-beta+
|
Details | Review |
Prerequisites
- Have the nimbus-cli tool installed.
- Have adb (cli) installed on your device.
- Have a device with USB or Wifi debugging enabled and connected to the device on which you installed nimbus-cli.
- Have the nimbus cli path added into the environment variable.
- Use a newly installed Firefox Nightly app.
Steps to reproduce
- Open a cmd window on the connected desktop or laptop.
- Run the following command:
nimbus-cli -a fenix -c nightly enroll preview/onboarding-customisation-options --branch treatment-a --no-validate
.
i. ensure that this experiment is in preview - Dismiss the default prompt and and all cards until you reach the "Theme" card.
- Tap the theme opposite to your system theme.
- Tap the secondary button and observe the behavior.
Expected behaviour
- The theme is reset and the next card is displayed.
Actual behaviour
- The selected theme remains set even though it was not saved.
Additional information
- The issue is reproducible on all branches that have the Theme card.
- The issue is reproducible on the following fenix versions:
- 135.0a1 (Build #2016063967), hg-b710be73841d+, GV: 135.0a1-20241225092003, AS: 135.20241220191521
Assignee | ||
Updated•2 months ago
|
Updated•2 months ago
|
Assignee | ||
Comment 1•2 months ago
|
||
When the user skips this card, the theme will be changed back
to the one of the system.
Updated•1 month ago
|
Updated•1 month ago
|
Assignee | ||
Comment 2•1 month ago
|
||
There was a bug with this button and after it was discussed about
it, it was concluded that the additional complexity to fix it was not
worth it so we are removing it. The user can still chose the default
(system) theme and we are still gonna get the same data.
Comment 4•1 month ago
|
||
bugherder |
Assignee | ||
Comment 5•1 month ago
|
||
Comment on attachment 9446577 [details]
Bug 1939266 - Remove secondary button for onboarding theme card
Beta/Release Uplift Approval Request
- User impact if declined/Reason for urgency: This fixes a high-priority UX bug raised by QA in https://bugzilla.mozilla.org/show_bug.cgi?id=1939242. This is an issue that can be discovered easily by users in onboarding, and resulted in a red QA sign-off email. Since Customization in Onboarding is targeting 135, QA requested that this fix be uplifted as soon as possible.
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: No
- Needs manual test from QE?: Yes
- If yes, steps to reproduce: For "Theme" card there should not be a secondary button.
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky):
- String changes made/needed:
- Is Android affected?: Yes
Assignee | ||
Updated•1 month ago
|
Comment 6•1 month ago
|
||
Comment on attachment 9446577 [details]
Bug 1939266 - Remove secondary button for onboarding theme card
Approved for 135.0b5.
Updated•1 month ago
|
Reporter | ||
Comment 8•1 month ago
|
||
I have verified that the Secondary button is no longer available even if a user would be in an experiment that is set up to have it. The verification was done on the latest Firefox Beta 135.0b5 (Build #2016068010), hg-d189e81741b3+, GV: 135.0-20250115091607, AS: 135.0 and Firefox Nightly 136.0a1 (Build #2016067967), hg-5904a2d552f2+, GV: 136.0a1-20250115042832, AS: 136.20250110050330.
Description
•