1939413 - lazy.SessionStore.getSavedTabGroups() is undefined

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect, P2)

Description

[Dale Harvey (:daleharvey)]

I have started seeing this recently, it looks like it prevent any actions from being shown. Nothing special about my profile and happens on relatively new profiles

Comment 1

[Dão Gottwald [:dao]]

I can't seem to be able to reproduce this. Do you still see this in the latest nightly?

Comment 2

[Dale Harvey (:daleharvey)]

Not seeing it in nightly but I am seeing it my local build.

At a guess its restoring from some unknown state and wiping the profile would fix it, can check what is in there or upload if you want but it seems like this._savedGroups is undefined.

Its a dev build so there always a chance I switched between branches and downgraded / did something unsupported.

Comment 3

[Dão Gottwald [:dao]]

Attachment: Bug 1939413 - Ensure _savedGroups isn't undefined. r?jswinarton,dwalker

Comment 4

[Dão Gottwald [:dao]]

Does the attached patch help in your local build?

Comment 5

[Dale Harvey (:daleharvey)]

Yup that fixes the issue for me

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/41b588610a79
Ensure _savedGroups isn't undefined. r=jswinarton,dwalker

Comment 7

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/41b588610a79