Closed Bug 1939558 Opened 1 month ago Closed 25 days ago

Add function parameter names and types to nrappkit function definitions

Categories

(Core :: WebRTC: Networking, task, P5)

task

Tracking

()

RESOLVED FIXED
136 Branch
Tracking Status
firefox136 --- fixed

People

(Reporter: cpeterson, Assigned: cpeterson)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

We currently compile Firefox's C code as C17 (bug 1932297). We won't be able to compile as C23 any time soon, but one of the blockers is that some nrappkit code still uses old-style K&R function definitions without function parameter types, which is no longer allowed in C23.

C23 no longer allows old-style K&R function definitions without function parameter types.

Attachment #9445409 - Attachment description: Bug 1939558 - Add function parameter names and types to nrappkit function definitions. r?#webrtc-reviewers → Bug 1939558 - Add function parameter names and types to nrappkit function definitions. r?bwc,#webrtc-reviewers
Pushed by cpeterson@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/13cca10f36cf Add function parameter names and types to nrappkit function definitions. r=webrtc-reviewers,bwc
Pushed by cpeterson@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8501a977440d Add function parameter names and types to nrappkit function definitions. r=webrtc-reviewers,bwc
Status: NEW → RESOLVED
Closed: 25 days ago
Resolution: --- → FIXED
Target Milestone: --- → 136 Branch
Flags: needinfo?(cpeterson)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: