Closed
Bug 1939558
Opened 1 month ago
Closed 25 days ago
Add function parameter names and types to nrappkit function definitions
Categories
(Core :: WebRTC: Networking, task, P5)
Core
WebRTC: Networking
Tracking
()
RESOLVED
FIXED
136 Branch
Tracking | Status | |
---|---|---|
firefox136 | --- | fixed |
People
(Reporter: cpeterson, Assigned: cpeterson)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
We currently compile Firefox's C code as C17 (bug 1932297). We won't be able to compile as C23 any time soon, but one of the blockers is that some nrappkit code still uses old-style K&R function definitions without function parameter types, which is no longer allowed in C23.
Assignee | ||
Comment 1•1 month ago
|
||
C23 no longer allows old-style K&R function definitions without function parameter types.
Updated•28 days ago
|
Attachment #9445409 -
Attachment description: Bug 1939558 - Add function parameter names and types to nrappkit function definitions. r?#webrtc-reviewers → Bug 1939558 - Add function parameter names and types to nrappkit function definitions. r?bwc,#webrtc-reviewers
Pushed by cpeterson@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/13cca10f36cf
Add function parameter names and types to nrappkit function definitions. r=webrtc-reviewers,bwc
Comment 3•28 days ago
|
||
Backed out for causing build bustages
Backout link: https://hg.mozilla.org/integration/autoland/rev/d70d446163f3b82652410bb02f3192d05443db0f
Flags: needinfo?(cpeterson)
Pushed by cpeterson@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8501a977440d
Add function parameter names and types to nrappkit function definitions. r=webrtc-reviewers,bwc
Comment 5•25 days ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 25 days ago
status-firefox136:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 136 Branch
Assignee | ||
Updated•14 days ago
|
Flags: needinfo?(cpeterson)
You need to log in
before you can comment on or make changes to this bug.
Description
•