Closed
Bug 1939736
Opened 1 month ago
Closed 1 month ago
Prompt abuser should support customized timeout
Categories
(Fenix :: App Links, enhancement)
Tracking
(firefox135 fixed, firefox136 fixed)
RESOLVED
FIXED
136 Branch
People
(Reporter: royang, Assigned: royang)
References
Details
(Whiteboard: [fxdroid][group3])
Attachments
(1 file)
48 bytes,
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-beta+
|
Details | Review |
Currently all usage of prompt abuser requires one second between dialog shown and user tap. However, in the applinks usecase this causes a weird case where the user can see the dialog but have to wait 1 second before tapping on the choice. Any tap before that 1 seconds elapses will not count and extends the timeout by another 1 second.
Prompt abuser should support customize time and also support that value in milliseconds.
Assignee | ||
Comment 1•1 month ago
|
||
Assignee | ||
Updated•1 month ago
|
Whiteboard: [fxdroid][group3]
Updated•1 month ago
|
Pushed by royang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/13286664454f
Support customized timeout for prompt abuser. r=android-reviewers,petru
Comment 3•1 month ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 1 month ago
status-firefox136:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 136 Branch
Assignee | ||
Comment 4•1 month ago
|
||
Comment on attachment 9445571 [details]
Bug 1939736 - Support customized timeout for prompt abuser.
Beta/Release Uplift Approval Request
- User impact if declined/Reason for urgency: Bug 1937373 requires this patch to land before uplift to beta
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): This change allows caller to customize delay time. But the default time is still what we had from before.,
- String changes made/needed: None
- Is Android affected?: Yes
Attachment #9445571 -
Flags: approval-mozilla-beta?
Comment 5•1 month ago
|
||
Comment on attachment 9445571 [details]
Bug 1939736 - Support customized timeout for prompt abuser.
Approved for 135.0b4.
Attachment #9445571 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Updated•29 days ago
|
status-firefox135:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•