Closed Bug 1939814 Opened 2 months ago Closed 2 months ago

4.12 - 2.15% Images Fresh start [+30s] / Images + 3 more (Linux, Windows) regression on Fri November 8 2024

Categories

(Firefox :: Address Bar, defect)

defect

Tracking

()

RESOLVED WONTFIX
Tracking Status
firefox-esr128 --- unaffected
firefox133 --- unaffected
firefox134 --- affected
firefox135 --- affected

People

(Reporter: intermittent-bug-filer, Unassigned)

References

(Regression)

Details

(Keywords: perf, perf-alert, regression)

Perfherder has detected a awsy performance regression from push 74d49a1535b4a51276e56112ff588a6a17782d9c. As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

Ratio Test Platform Options Absolute values (old vs new)
4% Images Fresh start [+30s] linux1804-64-shippable-qr fission tp6 1,307,876.67 -> 1,361,744.00
4% Images Fresh start [+30s] windows11-64-2009-shippable-qr fission tp6 1,476,949.33 -> 1,529,728.00
3% Images Tabs closed [+30s, forced GC] windows11-64-2009-shippable-qr fission tp6 1,622,238.00 -> 1,676,561.33
3% Images Tabs closed extra processes windows11-64-2009-shippable-qr fission tp6 2,777,934.00 -> 2,855,304.00
2% Images linux1804-64-shippable-qr fission tp6 5,170,001.72 -> 5,281,334.69

Improvements:

Ratio Test Platform Options Absolute values (old vs new)
0.49% Images windows11-64-2009-shippable-qr fission tp6 5,617,303.91 -> 5,589,875.12

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests. Please follow our guide to handling regression bugs and let us know your plans within 3 business days, or the patch(es) may be backed out in accordance with our regression policy.

If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a sheriff to do that for you.

You can run all of these tests on try with ./mach try perf --alert 43211

The following documentation link provides more information about this command.

For more information on performance sheriffing please see our FAQ.

If you have any questions, please do not hesitate to reach out to afinder@mozilla.com.

Flags: needinfo?(yalmacki)

Set release status flags based on info from the regressing bug 1928088

I took a look as I was confused why adding a fallback icon could cause a regression on image tests.

The issue is that we recently added a search engine icon onto the address bar when a new tab is displayed. Initially, there was no fallback icon but the search engine should have the application provided icon displayed. However, in ASWY tests, the way they are configured it looks like remote settings does not load the dumps for attachments as it sees that it is not on production.

Hence adding the fallback icon has added an extra icon that gets displayed during the tests.

From the performance test page, it says under "Possible Regressions":

A regression in this can indicate leaks or poor memory usage in the image subsystem. In the past this was a persistent problem.

Hence, if I understand that correctly, then we don't need to worry about this. Andrew, I think you are the owner here - can you confirm my assumption please?

Side note for the set-up: the attachments code for remote settings requires that the server URL be the production URL, or that we're running in tests mode (MOZ_DISABLE_NONLOCAL_CONNECTIONS=1). The server URL is set to a data URL - for performance tests, but it appears the disable non-local connections flag is not set. Hence it doesn't load the attachment dumps, otherwise we'd have seen this "regression" sooner.

Flags: needinfo?(yalmacki) → needinfo?(continuation)

Seems fine. Obviously it would be better if the test setup matched what are users get more closely but this seems like a minor issue.

Status: NEW → RESOLVED
Closed: 2 months ago
Flags: needinfo?(continuation)
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.