Closed Bug 1940033 Opened 1 month ago Closed 29 days ago

The session file is invalid: : TypeError: can't access property "hidden", state.windows[0] is undefined

Categories

(Firefox :: Session Restore, defect)

Firefox 135
Desktop
macOS
defect

Tracking

()

RESOLVED DUPLICATE of bug 1891433

People

(Reporter: claas, Unassigned)

References

(Depends on 1 open bug)

Details

In my Firefox Nightly (135.0a1 (2025-01-03) (aarch64)), the following session restore error happened: TypeError: can't access property "hidden", state.windows[0] is undefined

1735957868161	SessionStore	DEBUG	Successful file read of clean file
1735957868161	SessionStore	DEBUG	Completed SessionFile.read() with result.origin: clean
1735957868162	SessionStore	DEBUG	isAutomaticRestoreEnabled: true
1735957868162	SessionStore	DEBUG	Previous shutdown ok? false, reason: N/A
1735957868360	SessionStore	DEBUG	initialState contains 0 pinned tabs
1736153414446	SessionStore	DEBUG	initSession willRestore: true, SessionStartup.sessionType: 2
1736153414446	SessionStore	DEBUG	initSession, will autorestore
1736153414446	SessionStore	ERROR	The session file is invalid: : TypeError: can't access property "hidden", state.windows[0] is undefined(resource:///modules/sessionstore/SessionStore.sys.mjs:1275:11) JS Stack trace: initSession@SessionStore.sys.mjs:1275:11
onBeforeBrowserWindowShown/<@SessionStore.sys.mjs:2164:35
1736153414495	SessionStore	DEBUG	Restored 5 closed windows
1736153414495	SessionStore	DEBUG	restoreWindows will restore 0 windows
1736153414495	SessionStore	DEBUG	sessionstore-windows-restored
1736153414503	SessionStore	DEBUG	All 0 windows restored

I decompressed the previous.jsonlz4 session restore backup using https://github.com/sfoster/moz-sessionrestore-tools, and found that the windows list was empty:

{
  "version": [
    "sessionrestore",
    1
  ],
  "windows": [],
  "selectedWindow": 0,
  "_closedWindows": [
    // ...
  ],
  "savedGroups": [],
  "session": {
    "lastUpdate": 1735957856943,
    "startTime": 1647863522966,
    "recentCrashes": 0
  },
  "global": {},
  "cookies": [
    // ...
  ]
}
OS: Unspecified → macOS
Hardware: Unspecified → Desktop

Possibly a dupe of bug 1891433 ?

:claas, are the closed windows expected? Are any of those windows supposed to have been re-opened?

The logging tells us essentially that there was a problem saving/shutting down the session and that data was lost. So restore has no windows to restore. I don't suppose you remember any exceptions logged at that time?

Flags: needinfo?(caugner)
See Also: → 1891433

:sfoster, this happens occasionally, but in general I'm not too attached to my windows and tabs, so I don't always notice it.

Unfortunately, I don't remember exactly what I did the last time I used my Firefox on Friday. Usually, I just put my Macbook to sleep on Friday, and wake it back up on Monday, without quitting Firefox. I'm fairly sure that Firefox had the little dot below the logo in the macOS dock, because I usually notice when Firefox is not running at all.

PS: I did also experience an updater bug today, and shared some Browser Console errors.

Flags: needinfo?(caugner)

Bug 1903112 would give us the detailed logging necessary to troubleshoot this kind of issue - where something occurs which results in a empty session being written, and at session restore there's no detail or context there to explain why.

Depends on: 1903112

The severity field is not set for this bug.
:sclements, could you have a look please?

For more information, please visit BugBot documentation.

Flags: needinfo?(sclements)

I'm going to mark this as a dupe but feel free to add more information if that doesn't seem correct.

Status: NEW → RESOLVED
Closed: 29 days ago
Duplicate of bug: 1891433
Flags: needinfo?(sclements)
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.