Closed Bug 1940041 Opened 1 month ago Closed 1 month ago

if horizontal tab strip has a scroll offset, opening a link as new tab from a pinned tab stopped opening it in view (= scroll to it, scroll offset 0)

Categories

(Firefox :: Tabbed Browser, defect, P1)

defect

Tracking

()

RESOLVED FIXED
136 Branch
Tracking Status
firefox-esr115 --- unaffected
firefox-esr128 --- unaffected
firefox134 --- unaffected
firefox135 + disabled
firefox136 + fixed

People

(Reporter: aryx, Assigned: dao)

References

(Regression)

Details

(Keywords: regression)

Attachments

(1 file)

Firefox 135.0a1 20250105092842 on Windows 10

If

  • there are pinned tabs, and
  • enough non-pinned tabs to cause the horizontal tab strip to scroll, and
  • the tab strip has a scroll offset which hides the first non-pinned tab,
    then opening a link from a pinned tab in a new tab doesn't bring the new tab into view (= scroll the tab strip to the left where the new tab is).

Actual result:
Tab opened without noticing and direct access

Expected result:
New tab scrolled into view.

Dap: Should this be fixed in Beta or the change be reverted in Beta or in Beta and Central (today is the merge from Central to Beta)?

Flags: needinfo?(dao+bmo)
Component: Sidebar → Tabbed Browser

(In reply to Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout) from comment #0)

Firefox 135.0a1 20250105092842 on Windows 10

If

  • there are pinned tabs, and
  • enough non-pinned tabs to cause the horizontal tab strip to scroll, and
  • the tab strip has a scroll offset which hides the first non-pinned tab,
    then opening a link from a pinned tab in a new tab doesn't bring the new tab into view (= scroll the tab strip to the left where the new tab is).

Actual result:
Tab opened without noticing and direct access

Expected result:
New tab scrolled into view.

Dap: Should this be fixed in Beta or the change be reverted in Beta or in Beta and Central (today is the merge from Central to Beta)?

I'd say we should revert it on Beta, except that I can't seem to reproduce the bug with the above steps. Not sure what I'm missing :/

Flags: needinfo?(dao+bmo)
Severity: -- → S2
Priority: -- → P1
Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED
Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/16b2437248d9 Fix typo. r=tabbrowser-reviewers,sthompson
Status: ASSIGNED → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → 136 Branch
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: