Closed
Bug 1940064
Opened 1 month ago
Closed 1 month ago
Move GleanTest.js to SimpleTest dir
Categories
(Data Platform and Tools :: Glean: SDK, defect)
Data Platform and Tools
Glean: SDK
Tracking
(firefox136 fixed)
RESOLVED
FIXED
Tracking | Status | |
---|---|---|
firefox136 | --- | fixed |
People
(Reporter: fkilic, Assigned: fkilic)
References
Details
Attachments
(1 file)
This patch is intended to address this matrix message https://matrix.to/#/!SCdsJdSTaQHjzEVrAE:mozilla.org/$v3hxef0R2eOSU5yGMzIsEMOk19YVpMW5pxN4liBngIc?via=mozilla.org&via=matrix.org&via=ungleich.ch. In summary, prevent GleanTest.js duplication for different tests.
Assignee | ||
Comment 1•1 month ago
|
||
Pushed by fkilic@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d2c43097bd7a
Move GleanTest.js to SimpleTest dir. r=chutten,frontend-codestyle-reviewers
Comment 3•1 month ago
|
||
Backed out for causing documentation opt failures.
- Backout link
- Push with failures
- Failure Log
- Failure line: TEST-UNEXPECTED-FAILURE | ./mach doc | /builds/worker/checkouts/gecko/docs-out/html/_staging/toolkit/components/glean/user/instrumentation_tests.md:193: WARNING: Pygments lexer name '{admonition}Asynchronicity' is not known
Flags: needinfo?(fkilic)
Comment 4•1 month ago
•
|
||
Probably just needs a space between the }
and the A
?
This is a different custom admonition in the FOG docs to model it after.
Assignee | ||
Comment 6•1 month ago
•
|
||
It fixes the issue on my local build but I'll still wait for bot to generate docs to be extra sure.
Edit: decided to also wait for https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cpending%2Crunning%2Crunnable&revision=d2c43097bd7a61bd50dba95729ad832ea8b9e5ff
Pushed by fkilic@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7789d3621dda
Move GleanTest.js to SimpleTest dir. r=chutten,frontend-codestyle-reviewers
Comment 8•1 month ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 1 month ago
status-firefox136:
--- → fixed
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•