ProtoKeys break binary compatibility
Categories
(Core :: JavaScript Engine, defect, P2)
Tracking
()
People
(Reporter: sfink, Assigned: sfink, NeedInfo)
References
(Blocks 1 open bug, Regression)
Details
(Keywords: regression)
Attachments
(1 file)
js/public/ProtoKey.h has a mechanism for making proto keys have the same offset regardless of feature configuration, but it looks like we did it wrong for records & tuples as well as explicit resource management.
Reported by Tom Tang in #spidermonkey.
Assignee | ||
Comment 1•1 month ago
|
||
Updated•1 month ago
|
Comment 3•1 month ago
|
||
Backed out for causing build bustages at TestMaybe.cpp.
Backout link: https://hg.mozilla.org/integration/autoland/rev/20c7cc227a0119d555b34bf0498a7dbf3f998b14
Failure log:
https://treeherder.mozilla.org/logviewer?job_id=489130440&repo=autoland&lineNumber=89815
https://treeherder.mozilla.org/logviewer?job_id=489132203&repo=autoland&lineNumber=14234
Assignee | ||
Comment 4•1 month ago
|
||
(In reply to Atila Butkovits from comment #3)
Backed out for causing build bustages at TestMaybe.cpp.
Whoa! No good. I accidentally updated the patch to include a totally unrelated change.
I'm glad that test was there!
Comment 6•1 month ago
|
||
Backed out for causing bustages complaining about ProtoKey.
Backout link: https://hg.mozilla.org/integration/autoland/rev/bf40d95ccc9bf4bb1337d18ed853231b83382b7c
Push where failures started: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=e9254658cd1bf53b4a944f9985e3bcc2b3a6a28d&selectedTaskRun=LIiKMFoPTC-U6dd8vdTtQg.0
Failure log: https://treeherder.mozilla.org/logviewer?job_id=489144768&repo=autoland&lineNumber=31647
Comment 9•1 month ago
|
||
Backed out for causing build bustages in XrayWrapper.cpp.
- Backout link
- Push with failures
- Failure Log
- Failure line: /builds/worker/checkouts/gecko/js/xpconnect/wrappers/XrayWrapper.cpp(55,15): error: static assertion failed due to requirement 'JSProto_URIError - JSProto_Error == 8': New prototype added in error object range
Updated•1 month ago
|
Description
•