Open Bug 1940342 Opened 1 month ago Updated 1 month ago

ProtoKeys break binary compatibility

Categories

(Core :: JavaScript Engine, defect, P2)

defect

Tracking

()

ASSIGNED

People

(Reporter: sfink, Assigned: sfink, NeedInfo)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: regression)

Attachments

(1 file)

js/public/ProtoKey.h has a mechanism for making proto keys have the same offset regardless of feature configuration, but it looks like we did it wrong for records & tuples as well as explicit resource management.

Reported by Tom Tang in #spidermonkey.

Assignee: nobody → sphink
Status: NEW → ASSIGNED
Pushed by sfink@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/706338ae16dd Reserve slots for conditional proto keys for RECORD_TUPLE and EXPLICIT_RESOURCE_MANAGEMENT r=spidermonkey-reviewers,iain

(In reply to Atila Butkovits from comment #3)

Backed out for causing build bustages at TestMaybe.cpp.

Whoa! No good. I accidentally updated the patch to include a totally unrelated change.

I'm glad that test was there!

Flags: needinfo?(sphink)
Pushed by sfink@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/87dd25bcdd3b Reserve slots for conditional proto keys for RECORD_TUPLE and EXPLICIT_RESOURCE_MANAGEMENT r=spidermonkey-reviewers,iain

Heh. 3rd time's a charm?

Flags: needinfo?(sphink)
Pushed by sfink@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b7d0fd86b8b7 Reserve slots for conditional proto keys for RECORD_TUPLE and EXPLICIT_RESOURCE_MANAGEMENT r=spidermonkey-reviewers,iain

Backed out for causing build bustages in XrayWrapper.cpp.

  • Backout link
  • Push with failures
  • Failure Log
  • Failure line: /builds/worker/checkouts/gecko/js/xpconnect/wrappers/XrayWrapper.cpp(55,15): error: static assertion failed due to requirement 'JSProto_URIError - JSProto_Error == 8': New prototype added in error object range
Flags: needinfo?(sphink)
Severity: -- → S3
Priority: -- → P2
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: