Open Bug 1940348 Opened 1 month ago Updated 1 month ago

'New Tab' tab and button contain the same accessible name

Categories

(Firefox :: Tabbed Browser, defect)

Firefox 136
x86_64
Windows 10
defect

Tracking

()

Accessibility Severity s3
Tracking Status
firefox136 --- affected

People

(Reporter: nstroud, Unassigned, NeedInfo)

Details

(Keywords: access)

Attachments

(1 file)

Prerequisites:

Found in Nightly 136.0a1 (2025-01-07)
Turn on NVDA

STR:

  1. Open Firefox Nightly
  2. Move focus to the '+' icon button and press ENTER to open a new tab. Observe NVDA's output
  3. Move focus to the new tab that's open and observe NVDA's output

Expected / Actual:

Both the newly opened tab and the '+' icon button to open a new tab contain the same label: New tab. This can be confusing for screen reader users and difficult to differentiate that one opens a new tab and one is a newly opened tab.

Recommendation: change the label of the '+' icon button to 'Open a new tab'

Hmm, there should be an aria-label on the button with the value "Open a new tab (Ctrl+T)": https://searchfox.org/mozilla-central/rev/7d1b5c88343879056168aa710a9ee743392604c0/browser/components/tabbrowser/content/tabs.js#150-153
Do you know why NVDA wouldn't use the aria-label that we set?

No longer blocks: 1928439
Flags: needinfo?(nstroud)

(In reply to Dão Gottwald [:dao] from comment #1)

Hmm, there should be an aria-label on the button with the value "Open a new tab (Ctrl+T)": https://searchfox.org/mozilla-central/rev/7d1b5c88343879056168aa710a9ee743392604c0/browser/components/tabbrowser/content/tabs.js#150-153
Do you know why NVDA wouldn't use the aria-label that we set?

Hi Dao, the Open New Tab "+" button is a <toolbarbutton> which is a XUL element thus would need the label attribute to be set instead. Also, sometimes tooltip text is only rendered on hover, so maybe there is no value from the tooltip and no tooltip yet in the DOM for the aria-label to pull the string from as well?

Flags: needinfo?(nstroud) → needinfo?(dao+bmo)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: