Closed Bug 1940434 Opened 1 month ago Closed 29 days ago

Add a JS shell flag to match the WebAudio environment

Categories

(Core :: JavaScript Engine, task, P1)

task

Tracking

()

RESOLVED FIXED
136 Branch
Tracking Status
firefox136 --- fixed

People

(Reporter: nbp, Assigned: nbp)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Web Audio environment set some CPU flags which might change the way some JS operation behave, just for completeness, we should make sure that the JS shell offers a similar execution environment for anyone interested to reproduce this special case.

Pushed by npierron@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2cf7471462a9 Add JS shell option for emulating WebAudio worklets. r=jandem

Backed out for causing SM bustages @ denormals-1.js

TEST-UNEXPECTED-FAIL | js/src/jit-test/tests/self-test/denormals-1.js | /builds/worker/checkouts/gecko/js/src/jit-test/tests/self-test/denormals-1.js:3:9 Error: Assertion failed: got 5e-324, expected 0 (code 3, args "--disable-main-thread-denormals") [0.0 s]
Flags: needinfo?(nicolas.b.pierron)

The problem comes from the facts that:

  • getBuildConfiguration("arm") does not represent the compilation target of the JS shell but the target of the code generator.
  • the skip-if condition lacks a check equivalent to __GNUC__.

I will fix this issuer by mirroring the condition under GetBuildConfiguration, thus if there is any upcoming failure, this would be an implementation issue and not a test issue.

Flags: needinfo?(nicolas.b.pierron)
Pushed by npierron@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/be19578e8e3e Add JS shell option for emulating WebAudio worklets. r=jandem
Status: ASSIGNED → RESOLVED
Closed: 29 days ago
Resolution: --- → FIXED
Target Milestone: --- → 136 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: