Closed Bug 1940752 Opened 1 month ago Closed 21 days ago

Attempting to reopen a closed tab group from the "Reopen Closed Tab" tab context menu item does not work

Categories

(Firefox :: Session Restore, defect, P2)

defect
Points:
3

Tracking

()

RESOLVED FIXED
136 Branch
Tracking Status
firefox136 --- fixed

People

(Reporter: jswinarton, Assigned: jswinarton)

References

(Blocks 1 open bug, Regressed 1 open bug)

Details

(Whiteboard: [fidefe-tabgrps-sessionstore])

Attachments

(2 files)

Steps to reproduce:

  1. Open some tabs and load sites in them (i.e. not about:blank)
  2. Multi-select the tabs, right click, and select "Add Tabs to New Group". Close the tab group dialog by clicking "Done".
  3. Right click the tab group label and click "Delete group"
  4. Right click any other open tab, or the tab strip itself, and click "Reopen Closed Tabs"

Expected result:
All tabs reopen and are opened in their original group

Actual result:
Only one of the tabs in the original tab is re-opened, and it is ungrouped.

Blocks: 1907100
Severity: -- → S3
Points: --- → 3
Priority: -- → P2
Whiteboard: [fidefe-tabgrps]
Assignee: nobody → jswinarton
Whiteboard: [fidefe-tabgrps] → [fidefe-tabgrps-sessionstore]
Blocks: 1941799
Attachment #9460198 - Attachment description: WIP: Bug 1940752: 'Reopen Closed Tab' tab context menu, and other paths calling undoCloseTab, support tab groups → Bug 1940752: 'Reopen Closed Tab' tab context menu, and other paths calling undoCloseTab, support tab groups r?dao,dwalker
Pushed by jswinarton@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9d45c0c056cd 'Reopen Closed Tab' tab context menu, and other paths calling undoCloseTab, support tab groups r=dao,sessionstore-reviewers,tabbrowser-reviewers
Regressions: 1942953
Status: NEW → RESOLVED
Closed: 21 days ago
Resolution: --- → FIXED
Target Milestone: --- → 136 Branch

The last patch for this bug was backed out the first time I attempted to
land it. After I fixed the issue and re-landed, I accidentally left some
debug cruft that wasn't caught by the linter.

A patch has been attached on this bug, which was already closed. Filing a separate bug will ensure better tracking. If this was not by mistake and further action is needed, please alert the appropriate party. (Or: if the patch doesn't change behavior -- e.g. landing a test case, or fixing a typo -- then feel free to disregard this message)

Pushed by jswinarton@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1f551eaad637 Remove test debug logs forgotten in previous patch r=dao,sessionstore-reviewers
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: