Closed Bug 1940774 Opened 1 month ago Closed 14 days ago

First session ping submission does not include some attribution data

Categories

(Fenix :: Onboarding, defect)

All
Android
defect

Tracking

(firefox134 unaffected, firefox135 wontfix, firefox136 wontfix)

RESOLVED WONTFIX
Tracking Status
firefox134 --- unaffected
firefox135 --- wontfix
firefox136 --- wontfix

People

(Reporter: royang, Assigned: royang)

References

(Regression)

Details

(Keywords: regression, Whiteboard: [fxdroid][group3])

Attachments

(3 files)

Current implementation will not send any Adjust attribution data since install referrer always responds earlier than Adjust and since first session ping is only sent once it will not report Adjust attribution correctly.

See Also: → 1940777

Set release status flags based on info from the regressing bug 1934680

Whiteboard: [fxdroid][group3]
Pushed by royang@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/661c9d5002cf Wait till Adjust attribution data before triggering first session ping. r=android-reviewers,twhite
Status: NEW → RESOLVED
Closed: 25 days ago
Resolution: --- → FIXED
Target Milestone: --- → 136 Branch

The patch landed in nightly and beta is affected.
:royang, is this bug important enough to require an uplift?

  • If yes, please nominate the patch for beta approval.
  • If no, please set status-firefox135 to wontfix.

For more information, please visit BugBot documentation.

Flags: needinfo?(royang)

Comment on attachment 9446579 [details]
Bug 1940774 - Wait till Adjust attribution data before triggering first session ping.

Beta/Release Uplift Approval Request

  • User impact if declined/Reason for urgency: Adjust attributions won't be reported to Glean
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Moving back to an implementation that was stable before we disabled Adjust. This was well tested to work.
  • String changes made/needed: None
  • Is Android affected?: Yes
Flags: needinfo?(royang)
Attachment #9446579 - Flags: approval-mozilla-beta?

Comment on attachment 9446579 [details]
Bug 1940774 - Wait till Adjust attribution data before triggering first session ping.

Approved for 135.0b5.

Attachment #9446579 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

This reverts commit aa0b1bc0516ebd56489a96615804a4d9b7d449e8.

Pushed by royang@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/cf8949236eb6 Revert "Bug 1940774 - Wait till Adjust attribution data before triggering first session ping." r=android-reviewers,twhite

This reverts commit 2a0812488e898e302455c3bb01e1e3f976e5707b.

Attachment #9461513 - Flags: approval-mozilla-beta?

Comment on attachment 9461513 [details]
Revert "Bug 1940774 - Wait till Adjust attribution data before triggering first session ping."

Beta Uplift Approval Request

User impact if declined/Reason for urgency: Install referrer response won't be sent via Glean
Is this code covered by automated tests?: No
Has the fix been verified in Nightly?: Yes
Needs manual test from QE?: No
If yes, steps to reproduce:
List of other uplifts needed: None
Risk to taking this patch: Low
Why is the change risky/not risky? (and alternatives if risky): Adjust is disabled so we will wait till the new onboarding is done before re-enabling it.
String changes made/needed: None
Is Android affected?: Yes

Backed out changeset cf8949236eb6 for causing Fenix build bustages

Halting on failure while running ['/builds/worker/.mozbuild/srcdirs/gecko-8a5b87fe5d69/_virtualenvs/common/bin/python', 'mach', '--log-no-times', 'gradle', 'fenix:assembleDebug']
Flags: needinfo?(royang)
Status: RESOLVED → REOPENED
Flags: needinfo?(royang)
Resolution: FIXED → ---
Pushed by icedicedcoffee@proton.me: https://hg.mozilla.org/integration/autoland/rev/a31ab946dd1d Revert "Bug 1940774 - Wait till Adjust attribution data before triggering first session ping." r=android-reviewers,twhite
Attachment #9461513 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Per discussion with Roger, closing this as WONTFIX in favor of taking a different approach in a new bug.

Status: REOPENED → RESOLVED
Closed: 25 days ago14 days ago
Resolution: --- → WONTFIX
Target Milestone: 136 Branch → ---
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: