First session ping submission does not include some attribution data
Categories
(Fenix :: Onboarding, defect)
Tracking
(firefox134 unaffected, firefox135 wontfix, firefox136 wontfix)
Tracking | Status | |
---|---|---|
firefox134 | --- | unaffected |
firefox135 | --- | wontfix |
firefox136 | --- | wontfix |
People
(Reporter: royang, Assigned: royang)
References
(Regression)
Details
(Keywords: regression, Whiteboard: [fxdroid][group3])
Attachments
(3 files)
48 bytes,
text/x-phabricator-request
|
RyanVM
:
approval-mozilla-beta+
|
Details | Review |
48 bytes,
text/x-phabricator-request
|
Details | Review | |
48 bytes,
text/x-phabricator-request
|
phab-bot
:
approval-mozilla-beta+
|
Details | Review |
Current implementation will not send any Adjust attribution data since install referrer always responds earlier than Adjust and since first session ping is only sent once it will not report Adjust attribution correctly.
Assignee | ||
Comment 1•1 month ago
|
||
Comment 2•1 month ago
|
||
Set release status flags based on info from the regressing bug 1934680
Assignee | ||
Updated•28 days ago
|
Updated•28 days ago
|
Comment 4•25 days ago
|
||
bugherder |
Comment 5•25 days ago
|
||
The patch landed in nightly and beta is affected.
:royang, is this bug important enough to require an uplift?
- If yes, please nominate the patch for beta approval.
- If no, please set
status-firefox135
towontfix
.
For more information, please visit BugBot documentation.
Assignee | ||
Comment 6•25 days ago
|
||
Comment on attachment 9446579 [details]
Bug 1940774 - Wait till Adjust attribution data before triggering first session ping.
Beta/Release Uplift Approval Request
- User impact if declined/Reason for urgency: Adjust attributions won't be reported to Glean
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): Moving back to an implementation that was stable before we disabled Adjust. This was well tested to work.
- String changes made/needed: None
- Is Android affected?: Yes
Comment 7•24 days ago
|
||
Comment on attachment 9446579 [details]
Bug 1940774 - Wait till Adjust attribution data before triggering first session ping.
Approved for 135.0b5.
Updated•24 days ago
|
Assignee | ||
Comment 9•15 days ago
|
||
This reverts commit aa0b1bc0516ebd56489a96615804a4d9b7d449e8.
Comment 10•15 days ago
|
||
Assignee | ||
Comment 11•15 days ago
|
||
This reverts commit 2a0812488e898e302455c3bb01e1e3f976e5707b.
Updated•15 days ago
|
Assignee | ||
Comment 12•15 days ago
•
|
||
Comment on attachment 9461513 [details]
Revert "Bug 1940774 - Wait till Adjust attribution data before triggering first session ping."
Beta Uplift Approval Request
User impact if declined/Reason for urgency: Install referrer response won't be sent via Glean
Is this code covered by automated tests?: No
Has the fix been verified in Nightly?: Yes
Needs manual test from QE?: No
If yes, steps to reproduce:
List of other uplifts needed: None
Risk to taking this patch: Low
Why is the change risky/not risky? (and alternatives if risky): Adjust is disabled so we will wait till the new onboarding is done before re-enabling it.
String changes made/needed: None
Is Android affected?: Yes
Comment 13•15 days ago
•
|
||
Backed out changeset cf8949236eb6 for causing Fenix build bustages
- Backout link
- Push with failures
- Failure Log
- Failure log 2
- Failure line:
Halting on failure while running ['/builds/worker/.mozbuild/srcdirs/gecko-8a5b87fe5d69/_virtualenvs/common/bin/python', 'mach', '--log-no-times', 'gradle', 'fenix:assembleDebug']
Assignee | ||
Updated•15 days ago
|
Comment 14•15 days ago
|
||
Updated•14 days ago
|
Comment 15•14 days ago
|
||
uplift |
Comment 16•14 days ago
|
||
Per discussion with Roger, closing this as WONTFIX in favor of taking a different approach in a new bug.
Comment 17•14 days ago
|
||
Backout merged to central: https://hg.mozilla.org/mozilla-central/rev/a31ab946dd1d
Description
•