Closed Bug 1940812 Opened 1 month ago Closed 1 month ago

[wpt-sync] Sync PR 50001 - Another speculative fix for flaky touch WPT

Categories

(Core :: DOM: Events, task, P4)

task

Tracking

()

RESOLVED FIXED
136 Branch
Tracking Status
firefox136 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 50001 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/50001
Details from upstream follow.

David Awogbemila <awogbemila@chromium.org> wrote:

Another speculative fix for flaky touch WPT

Per the history[1], the fix in crrev.com/c/6149989 does not appear to
have succeeded. This patch makes another attempt borrowing logic from
waitForCompositorReady which has stronger implications about the
readiness of the compositor thread than waitForCompostiorCommit which
crrev.com/c/6149989 was based on.

[1] https://ci.chromium.org/ui/test/chromium/ninja%3A%2F%2F%3Aheadless_shell_wpt%2Fexternal%2Fwpt%2Ftouch-events%2Fsingle-touch.html?q=V%3Abuilder%3DLinux%2520Tests+V%3Aos%3DUbuntu-22.04+V%3Atest_suite%3Dheadless_shell_wpt_tests

R=mustaq@chromium.org

Bug: 385526611
Change-Id: I52bbd8023fe50c7076890efedf7caddbdfaa330c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6164303
Commit-Queue: David Awogbemila \<awogbemila@chromium.org>
Reviewed-by: Mustaq Ahmed \<mustaq@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1404305}

PR 50001 applied with additional changes from upstream: fb28acd40c4aeb82f70966411805dd11da7b9129
Component: web-platform-tests → DOM: Events
Product: Testing → Core

CI Results

Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 3 tests and 5 subtests

Status Summary

Firefox

OK : 3
PASS : 237
FAIL : 3

Chrome

OK : 3
PASS : 240

Safari

OK : 2
PASS : 2
FAIL : 12
ERROR: 1

Links

GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/29cf32ed26bf [wpt PR 50001] - Another speculative fix for flaky touch WPT, a=testonly
Status: NEW → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → 136 Branch
You need to log in before you can comment on or make changes to this bug.