194083 - Patch for the file mozilla/security/coreconf/QNX.mk

Status: RESOLVED WONTFIX

(NSS :: Build, defect, P2)

Description

[amardare]

User-Agent:       Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.0)
Build Identifier: Not applicable

I attached a patch for the file
mozilla/security/coreconf/QNX.mk
It contains photon ( qnx ) specific changes and should not affect the other 
platforms.
It allows you to succesfully build the security related files on a QNX 6.2.1 
system.


Reproducible: Always

Steps to Reproduce:
N/A
Actual Results:  
N/A

Expected Results:  
N/A

Comment 1

[amardare]

Attachment: Patch for the file mozilla/security/coreconf/QNX.mk

It contains photon ( qnx ) specific changes and should not affect the other
platforms.
It allows you to succesfully build the security related files on a QNX 6.2.1
system.

Comment 2

[Wan-Teh Chang]

Comment on attachment 114898 [details] [diff] [review]
Patch for the file       mozilla/security/coreconf/QNX.mk

1. Do you still want to support building with gcc?

2. Does QNX run on ppc architecture?  If it does, we should
keep the ifeq ($(OS_TEST),ppc) test.

Comment 3

[amardare]

>1. Do you still want to support building with gcc?
No, qcc should always be used.

>2. Does QNX run on ppc architecture?  If it does, we should
>keep the ifeq ($(OS_TEST),ppc) test.
We tried with the mips instead. You can keep the ppc line also, it doesn't hurt.
Thank you.

Comment 4

[Wan-Teh Chang]

Question: can you use the -Vgcc_ntox86 flag on non-x86 CPUs
(such as ppc)?

Comment 5

[Wan-Teh Chang]

Question: the definitions of CCC and CXX are different:

  CCC=qcc -Vgcc_ntox86
  CXX=qcc -lang-c++ -Vgcc_ntox86

Which one is correct?  (By the way, NSS does not use the
CXX variable.)

Comment 6

[Nelson Bolyard (seldom reads bugmail)]

Remove target milestone of 3.8, since these bugs didn't get into that release.

Comment 7

[Julien Pierre]

This bug was last touched more than 2.5 years ago, and has no target. Marking P2.

Comment 8

[timeless]

http://www.qnx.com/developers/docs/qnx_6.1_docs/neutrino/utilities/q/qcc.html

no x86 shouldn't be used for non x86
     
-V [version,]target
    The version number (optional) and the target name. If you specify version, qcc looks in ${QCC_CONF_PATH}/version for configuration files.

    The targets include:

        * gcc_ntox86
        * gcc_ntomipsle
        * gcc_ntomipsbe
        * gcc_ntoppcbe

    For a list of supported targets, specify -V?. 

and the two defs are fine, -lang-c++ only applies to c++ files, now given that nss doesn't currently have c++ files that means it can use the non -land-c++ line, however given that bug 171084 (filed before this bug) talks about compiling w/ a c++ compiler, having the right env vars available would be a good idea, because otherwise this poor port would die when you switched.

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee is inactive on Bugzilla, and this bug has priority 'P2'.
:beurdouche, could you have a look please?

For more information, please visit auto_nag documentation.

Comment 10

[Marco Castelluccio [:marco]]

We have modified the bot to only consider P1 as high priority, so I'm cancelling the needinfo here.