Closed Bug 1940913 Opened 1 month ago Closed 1 month ago

./mach lint --fix <path to .cpp file> is much slower than it should be

Categories

(Developer Infrastructure :: Lint and Formatting, defect)

defect

Tracking

(Not tracked)

RESOLVED DUPLICATE of bug 1597277

People

(Reporter: florian, Unassigned)

Details

Here's a profile captured using PYTHONPERFSUPPORT=1 samply record --include-args ./mach lint --fix xpcom/base/nsCycleCollector.cpp: https://share.firefox.dev/3W7Xfzp

There's 5 seconds of running pip and npm (that I don't need) before clang-format (which is what I actually wanted) starts, and completes the reformatting of my C++ file in 367ms.

I should have mentioned that there's this line printed in the terminal "error: problem with lint setup, skipping android-ac, android-api-lint, android-checkstyle, android-fenix, android-focus, android-format, android-javadoc, android-lint, android-test" before the expected "✖ 0 problems (0 errors, 2 warnings, 2 fixed)".

(In reply to Florian Quèze [:florian] from comment #0)

Here's a profile captured using PYTHONPERFSUPPORT=1 samply record --include-args ./mach lint --fix xpcom/base/nsCycleCollector.cpp: https://share.firefox.dev/3W7Xfzp

There's 5 seconds of running pip and npm (that I don't need) before clang-format (which is what I actually wanted) starts, and completes the reformatting of my C++ file in 367ms.

I think this is a duplicate of bug 1597277 - we currently run all setup functions before running the linters.

(In reply to Florian Quèze [:florian] from comment #1)

I should have mentioned that there's this line printed in the terminal "error: problem with lint setup, skipping android-ac, android-api-lint, android-checkstyle, android-fenix, android-focus, android-format, android-javadoc, android-lint, android-test" before the expected "✖ 0 problems (0 errors, 2 warnings, 2 fixed)".

This is bug 1571684.

Status: NEW → RESOLVED
Closed: 1 month ago
Duplicate of bug: 1597277
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.