./mach lint --fix <path to .cpp file> is much slower than it should be
Categories
(Developer Infrastructure :: Lint and Formatting, defect)
Tracking
(Not tracked)
People
(Reporter: florian, Unassigned)
Details
Here's a profile captured using PYTHONPERFSUPPORT=1 samply record --include-args ./mach lint --fix xpcom/base/nsCycleCollector.cpp
: https://share.firefox.dev/3W7Xfzp
There's 5 seconds of running pip and npm (that I don't need) before clang-format (which is what I actually wanted) starts, and completes the reformatting of my C++ file in 367ms.
Reporter | ||
Comment 1•1 month ago
|
||
I should have mentioned that there's this line printed in the terminal "error: problem with lint setup, skipping android-ac, android-api-lint, android-checkstyle, android-fenix, android-focus, android-format, android-javadoc, android-lint, android-test" before the expected "✖ 0 problems (0 errors, 2 warnings, 2 fixed)".
Comment 2•1 month ago
|
||
(In reply to Florian Quèze [:florian] from comment #0)
Here's a profile captured using
PYTHONPERFSUPPORT=1 samply record --include-args ./mach lint --fix xpcom/base/nsCycleCollector.cpp
: https://share.firefox.dev/3W7XfzpThere's 5 seconds of running pip and npm (that I don't need) before clang-format (which is what I actually wanted) starts, and completes the reformatting of my C++ file in 367ms.
I think this is a duplicate of bug 1597277 - we currently run all setup functions before running the linters.
(In reply to Florian Quèze [:florian] from comment #1)
I should have mentioned that there's this line printed in the terminal "error: problem with lint setup, skipping android-ac, android-api-lint, android-checkstyle, android-fenix, android-focus, android-format, android-javadoc, android-lint, android-test" before the expected "✖ 0 problems (0 errors, 2 warnings, 2 fixed)".
This is bug 1571684.
Description
•