194115 - self-extracting installer no longer looks for .xpi files in cwd

Status: VERIFIED FIXED

(SeaMonkey :: Installer, defect)

Description

[Sean Su]

This is breaking the self-extracting installer from running in the
"...\mozilla\Mozilla Setup" dir when user decides to save the downloaded files.

The installer should do one of the following:
 * add another option to the self-extracting installer code that simply
   indicates it to look in the current process' dir for the .xpi files
 * change the save download files code to save the uncompressed files from
   the self-extracting .exe file, instead of the self-extracting file itself.
 * change the way the self-extracting code looks for the .xpi file to default
   to looking in a subdir (from cwd) called "xpi", and also change where the
   save download files code saves the files so this format works.

Comment 1

[Samir Gehani]

Installer triage team: nsbeta1+/adt2 for option 3.

Comment 2

[Grace Bush]

*** Bug 197545 has been marked as a duplicate of this bug. ***

Comment 3

[Sean Su]

Attachment: patch v1.0

tentative patch.  not tested yet.

Comment 4

[Sean Su]

Attachment: patch v1.1

patch tested. this one works.

Comment 5

[Sean Su]

Attachment: patch v1.2

found a minor bug with previous patch.	this one fixes it.

Herer's what the patch does.  If the self-extracting installer is run, it will
lookg to see if "[cwd]\xpi" dir exists.  If so, it will pass that on to
setup.exe.

If the user chooses to save the downloaded files:
* Setup.exe will save the xpi files "...\Setup Mozilla\xp"i if the
self-extracting archive is saved to "...\Setup Mozilla"
* Setup.exe will save the xpi files "...\Setup Mozilla" if the setup.exe and
its support files are saved to "...\Setup Mozilla"

Comment 6

[Samir Gehani]

Comment on attachment 120529 [details] [diff] [review]
patch v1.2

Change destUninstall to destInstall if in fact this is saving installer files,
not uninstaller files as we dsicussed (in SaveInstallerFiles()).  Thanks.

Comment 7

[Sean Su]

Attachment: patch v1.3

new patch containing sgehani's suggestions.

Comment 8

[Samir Gehani]

Comment on attachment 121475 [details] [diff] [review]
patch v1.3

Requesting rs from jag.

Comment 9

[jag (Peter Annema)]

Comment on attachment 121475 [details] [diff] [review]
patch v1.3

rs=jag

Comment 10

[Sean Su]

Comment on attachment 121475 [details] [diff] [review]
patch v1.3

requesting approval1.4b.
The risk is not great.

The value of this fix is that users will be able run the installer that was
saved during the download (if they chose to save it).  There are cases where
this does not currently work right now, which means if the users tries to run
the installer from Mozilla\Setup Mozilla, it will download all the .xpis again
even if they are already there.

I've tested all the possible scenarios where this patch affects:
 * sea .exe file with .xpis in a xpi\ subdir
 * sea .exe file with _no_ .xpis in a xpi\subdir, but in cwd (should _not_ find
the .xpis in cwd in this case)
 * setup.exe files with .xpis in cwd
 * setup.exe files with .xpis in xpi\ subdir, but not in cwd (made sure this
does not work)

Comment 11

[(not reading, please use [e-mail] instead)]

Comment on attachment 121475 [details] [diff] [review]
patch v1.3

a=sspitzer

Comment 12

[Sean Su]

patch checked in.

Comment 13

[Grace Bush]

build 2003050104