1941164 - Crash in [@ mozilla::DecoderDoctorLogger::IsDDLoggingEnabled]

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect)

Description

[Ryan VanderMeulen [:RyanVM]]

Crash report: https://crash-stats.mozilla.org/report/index/39e9b48c-a62c-4b50-82e4-b93180250111

MOZ_CRASH Reason:

MOZ_RELEASE_ASSERT(mDrainState == DrainState::None)

Top 10 frames:

0  xul.dll  mozilla::DecoderDoctorLogger::IsDDLoggingEnabled()  dom/media/MediaFormatReader.h:478
0  xul.dll  mozilla::MediaFormatReader::OnDemuxFailed(mozilla::TrackInfo::TrackType, mozi...  dom/media/MediaFormatReader.cpp:0
1  xul.dll  mozilla::MediaFormatReader::OnAudioDemuxFailed(mozilla::MediaResult const&)  dom/media/MediaFormatReader.h:763
1  xul.dll  mozilla::MediaFormatReader::DoDemuxAudio::<lambda_85>::operator()(mozilla::Me...  dom/media/MediaFormatReader.cpp:1689
1  xul.dll  mozilla::MozPromise<RefPtr<mozilla::MediaTrackDemuxer::SamplesHolder>, mozill...  xpcom/threads/MozPromise.h:652
1  xul.dll  mozilla::MozPromise<RefPtr<mozilla::MediaTrackDemuxer::SamplesHolder>, mozill...  xpcom/threads/MozPromise.h:666
1  xul.dll  mozilla::MozPromise<RefPtr<mozilla::MediaTrackDemuxer::SamplesHolder>, mozill...  xpcom/threads/MozPromise.h:855
2  xul.dll  mozilla::MozPromise<bool, mozilla::MediaResult, 1>::ThenValueBase::DoResolveO...  xpcom/threads/MozPromise.h:621
2  xul.dll  mozilla::MozPromise<bool, mozilla::MediaResult, 1>::ThenValueBase::ResolveOrR...  xpcom/threads/MozPromise.h:488
3  xul.dll  mozilla::TaskQueue::Runner::Run()  xpcom/threads/TaskQueue.cpp:261

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1940883

:karlt, since you are the author of the regressor, bug 1940883, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[Karl Tomlinson (:karlt)]

The reasoning behind https://hg.mozilla.org/mozilla-central/rev/f594e6f00208 was not quite accurate because UpdateReceivedNewData() can allow Update to proceed when mSeekRequest.Exists().

However, Update() will return early anyway when decoder.mSeekRequest.Exists().

Still trying to understand how this state is reached.

Comment 3

[Karl Tomlinson (:karlt)]

https://crash-stats.mozilla.org/report/index/bddd1559-18c1-48fd-bac6-850cd0250111 is a clearer stack, and indicates that the demux failed with NS_ERROR_DOM_MEDIA_WAITING_FOR_DATA, but I haven't worked out why a demux and a drain would be in progress concurrently.

Comment 4

[Donal Meehan [:dmeehan]]

Setting Fx136 to fixed since the regressor was backed out of central
https://bugzilla.mozilla.org/show_bug.cgi?id=1940883#c19

Comment 5

[Karl Tomlinson (:karlt)]

Yes, https://hg.mozilla.org/mozilla-central/rev/45f68751c2a6677f127f1d1125aea72adce108af was the back-out that resolved this.