Closed Bug 1941256 Opened 1 month ago Closed 1 month ago

Crash in [@ mozilla::MediaFormatReader::DrainDecoder]

Categories

(Core :: Audio/Video: Playback, defect)

Unspecified
Windows 11
defect

Tracking

()

RESOLVED FIXED
136 Branch
Tracking Status
firefox-esr115 --- unaffected
firefox-esr128 --- unaffected
firefox134 --- unaffected
firefox135 --- unaffected
firefox136 + fixed

People

(Reporter: gsvelto, Unassigned)

References

(Regression)

Details

(Keywords: crash, regression)

Crash Data

Crash report: https://crash-stats.mozilla.org/report/index/95aeba76-ebb4-4f96-b4c7-c87a20250112

MOZ_CRASH Reason:

MOZ_DIAGNOSTIC_ASSERT(!IsExclusive || !mHaveRequest) (Using an exclusive promise in a non-exclusive fashion)

Top 10 frames:

0  xul.dll  mozilla::MozPromiseRequestHolder<mozilla::MozPromise<bool, nsresult, 0> >::Tr...  xpcom/threads/MozPromise.h:1627
1  xul.dll  mozilla::MozPromise<nsTArray<RefPtr<mozilla::MediaData> >, mozilla::MediaResu...  xpcom/threads/MozPromise.h:1135
1  xul.dll  mozilla::MediaFormatReader::DrainDecoder(mozilla::TrackInfo::TrackType)  dom/media/MediaFormatReader.cpp:2306
2  xul.dll  mozilla::MediaFormatReader::Update(mozilla::TrackInfo::TrackType)  dom/media/MediaFormatReader.cpp:2509
3  xul.dll  mozilla::detail::RunnableMethodArguments<const nsresult>::apply<mozilla::net:...  xpcom/threads/nsThreadUtils.h:1085
3  xul.dll  std::invoke(mozilla::detail::RunnableMethodArguments<const nsresult>::apply<m...  /builds/worker/fetches/vs/VC/Tools/MSVC/14.39.33519/include/type_traits:1739
3  xul.dll  std::_Apply_impl(mozilla::detail::RunnableMethodArguments<const nsresult>::ap...  /builds/worker/fetches/vs/VC/Tools/MSVC/14.39.33519/include/tuple:1077
3  xul.dll  std::apply(mozilla::detail::RunnableMethodArguments<const nsresult>::apply<mo...  /builds/worker/fetches/vs/VC/Tools/MSVC/14.39.33519/include/tuple:1088
3  xul.dll  mozilla::detail::RunnableMethodArguments<const nsresult>::apply(mozilla::net:...  xpcom/threads/nsThreadUtils.h:1083
3  xul.dll  mozilla::detail::RunnableMethodImpl<mozilla::net::HttpBackgroundChannelParent...  xpcom/threads/nsThreadUtils.h:1134

Just spotted this during nightly crash triage. I wonder if it's related to bug 1941164.

:karlt, since you are the author of the regressor, bug 1940883, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Flags: needinfo?(karlt)

There are also a few with the same signature with a different crash reason: MOZ_DIAGNOSTIC_ASSERT(!Exists())

eg bp-5408ec3b-143a-4df7-9b3f-1a7000250112

The bug is marked as tracked for firefox136 (nightly). However, the bug still isn't assigned.

:jimm, could you please find an assignee for this tracked bug? Given that it is a regression and we know the cause, we could also simply backout the regressor. If you disagree with the tracking decision, please talk with the release managers.

For more information, please visit BugBot documentation.

Flags: needinfo?(jmathies)

Setting Fx136 to fixed since the regressor was backed out of central
https://bugzilla.mozilla.org/show_bug.cgi?id=1940883#c19

Flags: needinfo?(jmathies)

Resolved by the back-out in https://hg.mozilla.org/mozilla-central/rev/45f68751c2a6677f127f1d1125aea72adce108af

Thanks for the bug report and comments. They might help me understand what is happening.

Status: NEW → RESOLVED
Closed: 1 month ago
Flags: needinfo?(karlt)
Resolution: --- → FIXED
Target Milestone: --- → 136 Branch
You need to log in before you can comment on or make changes to this bug.