Closed Bug 1941382 Opened 1 month ago Closed 1 month ago

Please add Herald group and rule for new "browser-installer-reviewers" group

Categories

(Conduit :: Phabricator, defect)

defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: nalexander, Assigned: dkl)

References

Details

Could we please add browser/installer to the regex that controls when the application-update-reviewers group is added to a patch? Thanks!

Actually, could we make this a new browser-installer-reviewers group, with a herald rule for browser/installer; and could we add me (:nalexander), Chris DuPuis (:cdupuis), and Nicholas Rishel (:nrishel) as members? Thanks!

Summary: Please update Herald rule for "application-update-reviewers" group → Please add Herald group and rule for new "browser-installer-reviewers" group
Assignee: nobody → dkl
Status: NEW → ASSIGNED
Status: ASSIGNED → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED

(In reply to David Lawrence [:dkl] from comment #2)

Done
https://phabricator.services.mozilla.com/project/profile/221
https://phabricator.services.mozilla.com/H474

dkl: could I trouble you to make that browser/installer/windows? I was wide of the mark. If you want the name of the group to include Windows as well, feel free to make it #windows-installer-reviewers or similar.

Flags: needinfo?(dkl)

(In reply to Nick Alexander :nalexander [he/him] from comment #3)

(In reply to David Lawrence [:dkl] from comment #2)

Done
https://phabricator.services.mozilla.com/project/profile/221
https://phabricator.services.mozilla.com/H474

dkl: could I trouble you to make that browser/installer/windows? I was wide of the mark. If you want the name of the group to include Windows as well, feel free to make it #windows-installer-reviewers or similar.

Updated
https://phabricator.services.mozilla.com/H474

Flags: needinfo?(dkl)
You need to log in before you can comment on or make changes to this bug.