1942592 - TypedArray.includes() doesn't work in Nightly

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect, P1)

Description

[Jaroslav Nejedlý]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:123.0) Gecko/20100101 Firefox/123.0 BigDickEnergy

Steps to reproduce:

I ran this code in console: new Uint32Array([0xffff0000]).includes(0xffff0000).

The version of Firefox is: nightly 136.0a1. The release channel is unaffected.

Actual results:

returned false

Expected results:

Should have returned true

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'DevTools::Console' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

:anba, since you are the author of the regressor, bug 1941001, could you take a look?

For more information, please visit BugBot documentation.

Comment 3

[Jan de Mooij [:jandem]]

Thanks for the report!

This is likely caused by the NumberEqualsInt32 check here.

Comment 4

[Jan de Mooij [:jandem]]

Using NumberEqualsInt64 may be the simplest fix. anba, I can post a patch for that if you're not working on something better.

A bit surprising that test262 doesn't have any tests for indexOf/includes/lastIndexOf on Uint32Array with a large uint32 value.

Comment 5

[André Bargull [:anba]]

Yeah, using NumberEqualsInt64 seems to be the easiest fix for now.

Comment 6

[Jan de Mooij [:jandem]]

Attachment: Bug 1942592 - Fix TypedArray includes/indexOf/lastIndexOf to handle large Uint32Array values correctly. r?anba!

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ccca39d284ff
Fix TypedArray includes/indexOf/lastIndexOf to handle large Uint32Array values correctly. r=anba

Comment 8

[amarc]

https://hg.mozilla.org/mozilla-central/rev/ccca39d284ff