sometime swipe to close tab not working
Categories
(Fenix :: Tabs, defect)
Tracking
(firefox134 unaffected, firefox135 unaffected, firefox136+ verified)
Tracking | Status | |
---|---|---|
firefox134 | --- | unaffected |
firefox135 | --- | unaffected |
firefox136 | + | verified |
People
(Reporter: raj.azharuddin, Assigned: 007)
References
(Regression)
Details
(Keywords: regression, Whiteboard: [fxdroid][group4])
Attachments
(2 files)
User Agent: Mozilla/5.0 (Android 15; Mobile; rv:136.0) Gecko/136.0 Firefox/136.0
Steps to reproduce:
In last version, most of them swipe to close tab not working
136.0a1 (Build #2016068674
Comment 1•26 days ago
|
||
I'm seeing this too.
Reporter | ||
Comment 2•26 days ago
|
||
Comment 3•26 days ago
|
||
Was that recorded in an emulator? I haven't been able to get it to repro there, only on my actual phone.
Reporter | ||
Comment 4•26 days ago
|
||
(In reply to Ryan VanderMeulen [:RyanVM] from comment #3)
Was that recorded in an emulator? I haven't been able to get it to repro there, only on my actual phone.
Screen record from my mobile
Comment 5•26 days ago
|
||
Bug 1904906 appears to have landed within the timeframe of this regression. Noah, is that a possible culprit here?
Updated•26 days ago
|
Updated•26 days ago
|
Assignee | ||
Comment 6•26 days ago
•
|
||
(In reply to Ryan VanderMeulen [:RyanVM] from comment #5)
Bug 1904906 appears to have landed within the timeframe of this regression. Noah, is that a possible culprit here?
Yeah, it's 100% the gesture rewrite that's in Nightly.
It's limited to only Nightly and it will not be riding the trains until the fix is stable, or we remove it because it's not the right direction or Google provides a fix to the library code we are no longer using.
Updated•26 days ago
|
Comment 7•25 days ago
|
||
The bug is marked as tracked for firefox136 (nightly). We have limited time to fix this, the soft freeze is in 8 days. However, the bug still isn't assigned.
:007, could you please find an assignee for this tracked bug? Given that it is a regression and we know the cause, we could also simply backout the regressor. If you disagree with the tracking decision, please talk with the release managers.
For more information, please visit BugBot documentation.
Assignee | ||
Comment 8•25 days ago
|
||
As part of Modifier.pointerInput
, we are able to provide a key
, similar to LaunchedEffect, to tell the Modifier to restart whenever that key
updates. By changing this from Unit
to our state
object, the gestures should now be properly enabled/disabled based on our gesture business logic (i.e. disabled when there is vertical scrolling or the Tabs Tray is in multi-selection).
Assignee | ||
Updated•25 days ago
|
Comment 11•25 days ago
|
||
Can QA please confirm if the issue is fixed? The STR should be the same for this and Bug 1904906 but I'm going to set the flag anyways
Comment 12•24 days ago
|
||
bugherder |
Comment 14•20 days ago
|
||
Verified as fixed in the latest Nightly 136.0a1 from 01/27. All tabs can be closed with swiping gestures now.
Tested with the same devices: Samsung Galaxy A53 5G (Android 14), Nothing Phone (2a) 5G (Android 14), OPPO A15s (Android 10).
Description
•