Closed Bug 1942735 Opened 26 days ago Closed 24 days ago

sometime swipe to close tab not working

Categories

(Fenix :: Tabs, defect)

Firefox 136
All
Android
defect

Tracking

(firefox134 unaffected, firefox135 unaffected, firefox136+ verified)

VERIFIED FIXED
136 Branch
Tracking Status
firefox134 --- unaffected
firefox135 --- unaffected
firefox136 + verified

People

(Reporter: raj.azharuddin, Assigned: 007)

References

(Regression)

Details

(Keywords: regression, Whiteboard: [fxdroid][group4])

Attachments

(2 files)

User Agent: Mozilla/5.0 (Android 15; Mobile; rv:136.0) Gecko/136.0 Firefox/136.0

Steps to reproduce:

In last version, most of them swipe to close tab not working
136.0a1 (Build #2016068674

I'm seeing this too.

Status: UNCONFIRMED → NEW
Ever confirmed: true

Was that recorded in an emulator? I haven't been able to get it to repro there, only on my actual phone.

Flags: needinfo?(raj.azharuddin)

(In reply to Ryan VanderMeulen [:RyanVM] from comment #3)

Was that recorded in an emulator? I haven't been able to get it to repro there, only on my actual phone.

Screen record from my mobile

Flags: needinfo?(raj.azharuddin)

Bug 1904906 appears to have landed within the timeframe of this regression. Noah, is that a possible culprit here?

Flags: needinfo?(nbond)
Severity: -- → S2
Whiteboard: [fxdroid][group4]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #5)

Bug 1904906 appears to have landed within the timeframe of this regression. Noah, is that a possible culprit here?

Yeah, it's 100% the gesture rewrite that's in Nightly.

It's limited to only Nightly and it will not be riding the trains until the fix is stable, or we remove it because it's not the right direction or Google provides a fix to the library code we are no longer using.

Flags: needinfo?(nbond)

The bug is marked as tracked for firefox136 (nightly). We have limited time to fix this, the soft freeze is in 8 days. However, the bug still isn't assigned.

:007, could you please find an assignee for this tracked bug? Given that it is a regression and we know the cause, we could also simply backout the regressor. If you disagree with the tracking decision, please talk with the release managers.

For more information, please visit BugBot documentation.

Flags: needinfo?(nbond)

As part of Modifier.pointerInput, we are able to provide a key, similar to LaunchedEffect, to tell the Modifier to restart whenever that key updates. By changing this from Unit to our state object, the gestures should now be properly enabled/disabled based on our gesture business logic (i.e. disabled when there is vertical scrolling or the Tabs Tray is in multi-selection).

Assignee: nobody → nbond
Status: NEW → ASSIGNED
Flags: needinfo?(nbond)
Pushed by npoon@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/fed3206664a8 Update the swipe gesture Modifier when the underlying state object has been updated. r=android-reviewers,npoon
Duplicate of this bug: 1942855

Can QA please confirm if the issue is fixed? The STR should be the same for this and Bug 1904906 but I'm going to set the flag anyways

Flags: qe-verify+
Status: ASSIGNED → RESOLVED
Closed: 24 days ago
Resolution: --- → FIXED
Target Milestone: --- → 136 Branch
Duplicate of this bug: 1943683

Verified as fixed in the latest Nightly 136.0a1 from 01/27. All tabs can be closed with swiping gestures now.
Tested with the same devices: Samsung Galaxy A53 5G (Android 14), Nothing Phone (2a) 5G (Android 14), OPPO A15s (Android 10).

Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: