Builtins: building in xul instead of separate library
Categories
(Core :: Security: PSM, enhancement)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox137 | --- | fixed |
People
(Reporter: anna.weine, Assigned: anna.weine)
References
(Blocks 1 open bug)
Details
(Keywords: perf-alert)
Attachments
(1 external file)
| Assignee | ||
Comment 1•1 year ago
|
||
Updated•1 year ago
|
Updated•1 year ago
|
Updated•1 year ago
|
Updated•1 year ago
|
Updated•1 year ago
|
Comment 3•1 year ago
|
||
Backed out for causing failures at test_builtins.js.
Backout link: https://hg.mozilla.org/integration/autoland/rev/daa3e4239d85fb3c3680871bc4c466bf5909f750
Failure log: https://treeherder.mozilla.org/logviewer?job_id=495628300&repo=autoland&lineNumber=3211
Comment 5•1 year ago
•
|
||
Backed out for causing conflicts while backing out Bug 1620998.
Comment 8•1 year ago
|
||
| bugherder | ||
Comment 9•1 year ago
|
||
Comment 10•1 year ago
|
||
The 240 KB increase in XUL section size is more than offset by the fact that we no longer need to load nssckbi.
Unfortunately it doesn't look like the build_metrics section size tests ever took nssckbi into account. But I grabbed a copy from the Feb 19 Nightly and ran size myself.
$ size nssckbi.dll
text data bss dec hex filename
331922 553 0 332475 512bb nssckbi.dll
So, had nssckbi been included in the section size tests, we would have seen a decrease of 100 KB rather than an increase of 240 KB.
Comment 11•1 year ago
|
||
(In reply to Pulsebot from comment #7)
Pushed by nkulatova@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/77b89b1fd8ab
Builtins: building in xul instead of separate library
r=glandium,keeler,geckoview-reviewers,browser-installer-reviewers,nalexander,
owlish,jschanck
Perfherder has detected a build_metrics performance change from push 77b89b1fd8abb6c6e6fbce66f8edfda7dcbf8be7.
Improvements:
| Ratio | Test | Platform | Options | Absolute values (old vs new) |
|---|---|---|---|---|
| 8% | build times | windows2012-32-shippable | nightly taskcluster-projects/970387039909/machineTypes/c2-standard-16 | 3,363.13 -> 3,109.92 |
| 0.23% | installer size | osx-aarch64-shippable | aarch64 nightly | 98,795,782.33 -> 98,571,381.25 |
Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests.
If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a sheriff to do that for you.
You can run these tests on try with ./mach try perf --alert 44062
For more information on performance sheriffing please see our FAQ.
Description
•