Closed Bug 1942805 Opened 1 year ago Closed 1 year ago

Builtins: building in xul instead of separate library

Categories

(Core :: Security: PSM, enhancement)

enhancement

Tracking

()

RESOLVED FIXED
137 Branch
Tracking Status
firefox137 --- fixed

People

(Reporter: anna.weine, Assigned: anna.weine)

References

(Blocks 1 open bug)

Details

(Keywords: perf-alert)

Attachments

(1 external file)

No description provided.
Attachment #9460685 - Attachment description: WIP: Bug 1942805 - Builtins: building in xul instead of separate library → Bug 1942805 - Builtins: building in xul instead of separate library
Attachment #9460685 - Attachment description: Bug 1942805 - Builtins: building in xul instead of separate library → WIP: Bug 1942805 - Builtins: building in xul instead of separate library
Attachment #9460685 - Attachment description: WIP: Bug 1942805 - Builtins: building in xul instead of separate library → Bug 1942805 - Builtins: building in xul instead of separate library
Attachment #9460685 - Attachment description: Bug 1942805 - Builtins: building in xul instead of separate library → WIP: Bug 1942805 - Builtins: building in xul instead of separate library
Attachment #9460685 - Attachment description: WIP: Bug 1942805 - Builtins: building in xul instead of separate library → Bug 1942805 - Builtins: building in xul instead of separate library
Blocks: 1946459
Pushed by nkulatova@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/252a1b94c754 Builtins: building in xul instead of separate library r=glandium,keeler,geckoview-reviewers,browser-installer-reviewers,nalexander,owlish
Pushed by nkulatova@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b840c4565b11 Builtins: building in xul instead of separate library r=glandium,keeler,geckoview-reviewers,browser-installer-reviewers,nalexander,owlish

Backed out for causing conflicts while backing out Bug 1620998.

Backout by csabou@mozilla.com: https://hg.mozilla.org/mozilla-central/rev/3e935b711f3f Backed out 10 changesets (bug 1942805, bug 1620998) for causing grandle and ui failures.
Pushed by nkulatova@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/77b89b1fd8ab Builtins: building in xul instead of separate library r=glandium,keeler,geckoview-reviewers,browser-installer-reviewers,nalexander,owlish,jschanck
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 137 Branch

On Windows, reduced the installer size by 60KB, while increasing the XUL size by 240KB.

The 240 KB increase in XUL section size is more than offset by the fact that we no longer need to load nssckbi.

Unfortunately it doesn't look like the build_metrics section size tests ever took nssckbi into account. But I grabbed a copy from the Feb 19 Nightly and ran size myself.

$ size nssckbi.dll
   text	   data	    bss	    dec	    hex	filename
 331922	    553	      0	 332475	  512bb	nssckbi.dll

So, had nssckbi been included in the section size tests, we would have seen a decrease of 100 KB rather than an increase of 240 KB.

Flags: needinfo?(anna.weine)

(In reply to Pulsebot from comment #7)

Pushed by nkulatova@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/77b89b1fd8ab
Builtins: building in xul instead of separate library
r=glandium,keeler,geckoview-reviewers,browser-installer-reviewers,nalexander,
owlish,jschanck

Perfherder has detected a build_metrics performance change from push 77b89b1fd8abb6c6e6fbce66f8edfda7dcbf8be7.

Improvements:

Ratio Test Platform Options Absolute values (old vs new)
8% build times windows2012-32-shippable nightly taskcluster-projects/970387039909/machineTypes/c2-standard-16 3,363.13 -> 3,109.92
0.23% installer size osx-aarch64-shippable aarch64 nightly 98,795,782.33 -> 98,571,381.25

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests.

If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a sheriff to do that for you.

You can run these tests on try with ./mach try perf --alert 44062

For more information on performance sheriffing please see our FAQ.

Keywords: perf-alert
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: