Closed
Bug 1943064
Opened 27 days ago
Closed 21 days ago
[NotifyDatasetChanged] Use DiffUtils in AndroidComponents: LoginsAdapter instead of NotifyDatasetChanged
Categories
(Fenix :: Performance, task)
Tracking
(firefox136 fixed)
RESOLVED
FIXED
136 Branch
Tracking | Status | |
---|---|---|
firefox136 | --- | fixed |
People
(Reporter: titouan, Assigned: npoon)
References
(Blocks 1 open bug)
Details
(Whiteboard: [fxdroid][group4])
Attachments
(2 files)
Used when Fenix is used as a password manager for another app.
On the keyboard button that appears, use “Search logins”, this will show a search field and the results will be shown using the LoginsAdapter.
This can easily benefit from the use of ListAdapter with DiffUtils.
Reporter | ||
Updated•27 days ago
|
Assignee | ||
Updated•25 days ago
|
Assignee: nobody → npoon
Status: NEW → ASSIGNED
Whiteboard: [fxdroid][group4]
Updated•25 days ago
|
Assignee | ||
Comment 1•25 days ago
|
||
Pushed by npoon@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/76db2b94e5ac
Use ListAdapter on LoginsAdapter without notifyDataSetChanged r=android-reviewers,tthibaud
Comment 3•21 days ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 21 days ago
status-firefox136:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 136 Branch
Assignee | ||
Comment 4•19 days ago
|
||
Comment 5•18 days ago
|
||
A patch has been attached on this bug, which was already closed. Filing a separate bug will ensure better tracking. If this was not by mistake and further action is needed, please alert the appropriate party. (Or: if the patch doesn't change behavior -- e.g. landing a test case, or fixing a typo -- then feel free to disregard this message)
Pushed by npoon@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f193013106c4
Remove notifyDataSetChanged lint suppression from LoginsAdapter r=android-reviewers,calu,007
Comment 7•14 days ago
|
||
bugherder |
You need to log in
before you can comment on or make changes to this bug.
Description
•