Closed Bug 1943064 Opened 27 days ago Closed 21 days ago

[NotifyDatasetChanged] Use DiffUtils in AndroidComponents: LoginsAdapter instead of NotifyDatasetChanged

Categories

(Fenix :: Performance, task)

All
Android
task

Tracking

(firefox136 fixed)

RESOLVED FIXED
136 Branch
Tracking Status
firefox136 --- fixed

People

(Reporter: titouan, Assigned: npoon)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fxdroid][group4])

Attachments

(2 files)

2 usages: usage #1, usage 2

Used when Fenix is used as a password manager for another app.
On the keyboard button that appears, use “Search logins”, this will show a search field and the results will be shown using the LoginsAdapter.

This can easily benefit from the use of ListAdapter with DiffUtils.

Blocks: 1943106
No longer blocks: 1927435
Assignee: nobody → npoon
Status: NEW → ASSIGNED
Whiteboard: [fxdroid][group4]
Pushed by npoon@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/76db2b94e5ac Use ListAdapter on LoginsAdapter without notifyDataSetChanged r=android-reviewers,tthibaud
Status: ASSIGNED → RESOLVED
Closed: 21 days ago
Resolution: --- → FIXED
Target Milestone: --- → 136 Branch

A patch has been attached on this bug, which was already closed. Filing a separate bug will ensure better tracking. If this was not by mistake and further action is needed, please alert the appropriate party. (Or: if the patch doesn't change behavior -- e.g. landing a test case, or fixing a typo -- then feel free to disregard this message)

Pushed by npoon@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f193013106c4 Remove notifyDataSetChanged lint suppression from LoginsAdapter r=android-reviewers,calu,007
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: