Closed Bug 1943072 Opened 25 days ago Closed 18 days ago

4.88 - 4.47% damp browser-toolbox.inspector-ready.DAMP / damp browser-toolbox.inspector-ready.DAMP (OSX, Windows) regression on Thu January 16 2025

Categories

(Firefox :: Sidebar, defect)

defect

Tracking

()

RESOLVED WONTFIX
Tracking Status
firefox-esr128 --- unaffected
firefox134 --- unaffected
firefox135 --- unaffected
firefox136 --- affected

People

(Reporter: intermittent-bug-filer, Unassigned)

References

(Regression)

Details

(4 keywords, Whiteboard: [fidefe-sidebar])

Perfherder has detected a devtools performance regression from push 34f28da9e8d593cc53458fda8caefc688ea58d56. As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

Ratio Test Platform Options Absolute values (old vs new)
5% damp browser-toolbox.inspector-ready.DAMP windows11-64-shippable-qr e10s fission stylo webrender 235.00 -> 246.47
4% damp browser-toolbox.inspector-ready.DAMP macosx1470-64-shippable e10s fission stylo webrender 345.42 -> 360.88

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests. Please follow our guide to handling regression bugs and let us know your plans within 3 business days, or the patch(es) may be backed out in accordance with our regression policy.

If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a sheriff to do that for you.

You can run all of these tests on try with ./mach try perf --alert 43382

The following documentation link provides more information about this command.

For more information on performance sheriffing please see our FAQ.

If you have any questions, please do not hesitate to reach out to bacasandrei@mozilla.com.

Flags: needinfo?(kcochrane)

Set release status flags based on info from the regressing bug 1921060

Flags: needinfo?(kcochrane)
Whiteboard: [fidefe-sidebar]

:kcochrane, since you are the author of the regressor, bug 1921060, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Flags: needinfo?(kcochrane)

FYI, Kelly is off today but is planning to work on this regression tomorrow.

I reached out to :jdescottes in the DevTools matrix channel, and said given my changeset, it's very likely that you are slightly changing the markup / events / style the browser toolbox needs to display when starting the browser toolbox inspector. Their guess is that it's a bit slower to open because it needs to display more data, but that's not really something we should worry about. It's unlikely I actually regressed the performance of the Browser Toolbox.

WONTFIXing this given the above.

Status: NEW → RESOLVED
Closed: 18 days ago
Flags: needinfo?(kcochrane)
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.