Closed Bug 1943095 Opened 24 days ago Closed 23 days ago

Clean-up some code in TypeAnalyzer::adjustPhiInputs

Categories

(Core :: JavaScript Engine: JIT, task)

task

Tracking

()

RESOLVED FIXED
136 Branch
Tracking Status
firefox136 --- fixed

People

(Reporter: anba, Assigned: anba)

Details

Attachments

(4 files)

No description provided.

Reorder the code to share the MBox and MUnbox creation.

Replace the MIRType::Value-typed input with replacement, which is
MIRType::Double- typed. That way MToFloat32 is lowered to the infallible
LDoubleToFloat32 instead of LValueToFloat32.

MToDouble and MToFloat32 with number inputs are never fallible, so they
don't need a bailout kind.

Code generation supports LUnboxFloatingPoint with MIRType::Float32, but
all other parts in Ion expect that MUnbox never uses MIRType::Float32.

Pushed by andre.bargull@gmail.com: https://hg.mozilla.org/integration/autoland/rev/3ac138a528c7 Part 1: Remove duplicate code in TypeAnalyzer::adjustPhiInputs. r=iain https://hg.mozilla.org/integration/autoland/rev/5cd159845f5c Part 2: Make MToFloat32 infallible in TypeAnalyzer::adjustPhiInputs. r=iain https://hg.mozilla.org/integration/autoland/rev/ff6ce052b582 Part 3: Only set bailout kind for MUnbox. r=iain https://hg.mozilla.org/integration/autoland/rev/9654a7af01db Part 4: Remove unused LUnboxFloatingPoint with Float32. r=iain
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: