Closed Bug 1943390 Opened 26 days ago Closed 26 days ago

firefox nightly fails to compile with: image/decoders/nsPNGDecoder.cpp:435:40: error: PNG_INFO_cICP' was not declared in this scope

Categories

(Core :: Graphics: ImageLib, defect)

Firefox 136
defect

Tracking

()

RESOLVED FIXED
136 Branch
Tracking Status
firefox-esr128 --- unaffected
firefox134 --- unaffected
firefox135 --- unaffected
firefox136 --- fixed

People

(Reporter: herrtimson, Assigned: tnikkel)

References

(Regression)

Details

(Keywords: regression)

Attachments

(2 files)

Attached file build.log.xz

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:128.0) Gecko/20100101 Firefox/128.0

Steps to reproduce:

hi, I downloaded latest git snapshot from today and compiled it for armv7a

Actual results:

the build fails to compile with:

29:34.29 In file included from Unified_cpp_image_decoders0.cpp:74:
29:34.29 /var/tmp/portage/portage/www-client/firefox-136.0/work/firefox-136.0/image/decoders/nsPNGDecoder.cpp: In member function 'uint32_t mozilla::image::nsPNGDecoder::ReadColorProfile(png_structp, png_infop, int, bool*)':
29:34.29 /var/tmp/portage/portage/www-client/firefox-136.0/work/firefox-136.0/image/decoders/nsPNGDecoder.cpp:435:40: error: 'PNG_INFO_cICP' was not declared in this scope; did you mean 'PNG_INFO_iCCP'?
29:34.30 435 | if (png_get_valid(png_ptr, info_ptr, PNG_INFO_cICP)) {
29:34.30 | ^~~~~~~~~~~~~
29:34.30 | PNG_INFO_iCCP
29:34.30 /var/tmp/portage/portage/www-client/firefox-136.0/work/firefox-136.0/image/decoders/nsPNGDecoder.cpp:440:9: error: 'png_get_cICP' was not declared in this scope; did you mean 'png_get_iCCP'?
29:34.30 440 | if (png_get_cICP(png_ptr, info_ptr, &primaries, &tc, &matrix_coefficients,
29:34.30 | ^~~~~~~~~~~~
29:34.31 | png_get_iCCP

Expected results:

do you need any specific new version of libpng to build against? I've been using libpng-1.6.43 for this:

0:10.12 checking for libpng >= 1.6.35... yes

the full and compressed build log is attached

Keywords: regression
Regressed by: 1862245

The Bugbug bot thinks this bug should belong to the 'Core::Graphics: ImageLib' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Component: Untriaged → Graphics: ImageLib
Product: Firefox → Core

:tnikkel, since you are the author of the regressor, bug 1862245, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Flags: needinfo?(tnikkel)

Yes, you need 1.6.45 (or later, but that is currently the latest)

can you please add it to configure, i.e. scanning for >=libpng-1.6.45?

Severity: -- → S3
Assignee: nobody → tnikkel
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true

Thanks for the report. The attached patch should hopefully resolve the issue. Let me know if it doesn't.

Flags: needinfo?(tnikkel)

Set release status flags based on info from the regressing bug 1862245

Pushed by tnikkel@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2e3c6032cb0c Bump required version of libpng when using system libpng to 1.6.45. r=gfx-reviewers,ErichDonGubler
Status: ASSIGNED → RESOLVED
Closed: 26 days ago
Resolution: --- → FIXED
Target Milestone: --- → 136 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: