firefox nightly fails to compile with: image/decoders/nsPNGDecoder.cpp:435:40: error: PNG_INFO_cICP' was not declared in this scope
Categories
(Core :: Graphics: ImageLib, defect)
Tracking
()
Tracking | Status | |
---|---|---|
firefox-esr128 | --- | unaffected |
firefox134 | --- | unaffected |
firefox135 | --- | unaffected |
firefox136 | --- | fixed |
People
(Reporter: herrtimson, Assigned: tnikkel)
References
(Regression)
Details
(Keywords: regression)
Attachments
(2 files)
User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:128.0) Gecko/20100101 Firefox/128.0
Steps to reproduce:
hi, I downloaded latest git snapshot from today and compiled it for armv7a
Actual results:
the build fails to compile with:
29:34.29 In file included from Unified_cpp_image_decoders0.cpp:74:
29:34.29 /var/tmp/portage/portage/www-client/firefox-136.0/work/firefox-136.0/image/decoders/nsPNGDecoder.cpp: In member function 'uint32_t mozilla::image::nsPNGDecoder::ReadColorProfile(png_structp, png_infop, int, bool*)':
29:34.29 /var/tmp/portage/portage/www-client/firefox-136.0/work/firefox-136.0/image/decoders/nsPNGDecoder.cpp:435:40: error: 'PNG_INFO_cICP' was not declared in this scope; did you mean 'PNG_INFO_iCCP'?
29:34.30 435 | if (png_get_valid(png_ptr, info_ptr, PNG_INFO_cICP)) {
29:34.30 | ^~~~~~~~~~~~~
29:34.30 | PNG_INFO_iCCP
29:34.30 /var/tmp/portage/portage/www-client/firefox-136.0/work/firefox-136.0/image/decoders/nsPNGDecoder.cpp:440:9: error: 'png_get_cICP' was not declared in this scope; did you mean 'png_get_iCCP'?
29:34.30 440 | if (png_get_cICP(png_ptr, info_ptr, &primaries, &tc, &matrix_coefficients,
29:34.30 | ^~~~~~~~~~~~
29:34.31 | png_get_iCCP
Expected results:
do you need any specific new version of libpng to build against? I've been using libpng-1.6.43 for this:
0:10.12 checking for libpng >= 1.6.35... yes
the full and compressed build log is attached
Comment 1•26 days ago
|
||
The Bugbug bot thinks this bug should belong to the 'Core::Graphics: ImageLib' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.
Comment 2•26 days ago
|
||
:tnikkel, since you are the author of the regressor, bug 1862245, could you take a look? Also, could you set the severity field?
For more information, please visit BugBot documentation.
can you please add it to configure, i.e. scanning for >=libpng-1.6.45?
Announcement that 1.6.45 adds cICP support:
https://sourceforge.net/p/png-mng/mailman/png-mng-announce/?viewmonth=202501
Updated•26 days ago
|
Assignee | ||
Comment 6•26 days ago
|
||
1.6.45 added cicp support which we use.
Updated•26 days ago
|
Assignee | ||
Comment 7•26 days ago
|
||
Thanks for the report. The attached patch should hopefully resolve the issue. Let me know if it doesn't.
Comment 8•26 days ago
|
||
Set release status flags based on info from the regressing bug 1862245
Comment 10•26 days ago
|
||
bugherder |
Description
•