Update the ToS Onboarding card UI to match the final copy
Categories
(Fenix :: Onboarding, task)
Tracking
(firefox136 fixed)
Tracking | Status | |
---|---|---|
firefox136 | --- | fixed |
People
(Reporter: mavduevskiy, Assigned: mavduevskiy)
Details
Attachments
(3 files, 2 obsolete files)
The Figma file has been updated as of today, (hopefully) being finalized. Some smaller things like spacing here and there differ from what we have in the app. Figma link could be found in jira.
Assignee | ||
Updated•25 days ago
|
Assignee | ||
Comment 1•21 days ago
|
||
Assignee | ||
Comment 2•21 days ago
|
||
Assignee | ||
Comment 3•21 days ago
|
||
Assignee | ||
Comment 4•21 days ago
•
|
||
Should I remove the cancel button? The final design doesn't have it, but I see that there is a bunch a logic on the store level that has to be removed. And it looks like it explicit supported a case where the checked stated wouldn't applied until the done button would apply. Would appreciate any additional context.
Updated•21 days ago
|
Updated•21 days ago
|
Updated•21 days ago
|
Assignee | ||
Comment 5•21 days ago
|
||
This change is meant to avoid the case where the dialog is opened after changing preferencies and the switches are animated to their default positions as if they have been clicked. It happenes because the store is initiazlied with hardcoded default values, which are immidiately updated from by repository. And if they are different, composable are drawn twice, with the default store values and with updated values.
Assignee | ||
Comment 6•19 days ago
|
||
This patch aims to clean up data flow by simplifying repository interactions. The code as it is has some unwated side effects: init action triggers telemetry updates, and changing in settings triggers telemetry twice. The simpliest solution that I can think of is introduction of separate update and toggle actions, one for data change, the other for the user interaction, so that we only trigger telemetry on the user interaction.
It's a draft without documentation and tests, wanted to get early feedback.
Updated•18 days ago
|
Updated•18 days ago
|
Comment 8•17 days ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/ad33e4c82423
https://hg.mozilla.org/mozilla-central/rev/136705688505
https://hg.mozilla.org/mozilla-central/rev/2fb4e198ee3e
Description
•