Closed Bug 1943439 Opened 25 days ago Closed 17 days ago

Update the ToS Onboarding card UI to match the final copy

Categories

(Fenix :: Onboarding, task)

All
Android
task

Tracking

(firefox136 fixed)

RESOLVED FIXED
136 Branch
Tracking Status
firefox136 --- fixed

People

(Reporter: mavduevskiy, Assigned: mavduevskiy)

Details

Attachments

(3 files, 2 obsolete files)

The Figma file has been updated as of today, (hopefully) being finalized. Some smaller things like spacing here and there differ from what we have in the app. Figma link could be found in jira.

Assignee: nobody → mavduevskiy

Should I remove the cancel button? The final design doesn't have it, but I see that there is a bunch a logic on the store level that has to be removed. And it looks like it explicit supported a case where the checked stated wouldn't applied until the done button would apply. Would appreciate any additional context.

Flags: needinfo?(towhite)
Attachment #9462100 - Attachment description: WIP: Bug 1943439 - Part 1: Update tos onboarding page → Bug 1943439 - Part 1: Update tos onboarding page
Attachment #9462101 - Attachment description: WIP: Bug 1943439 - Part 2: Add styling parameter to switch label composable → Bug 1943439 - Part 2: Add styling parameter to switch label composable
Attachment #9462102 - Attachment description: WIP: Bug 1943439 - Part 3: Update manage privacy dialog ui → Bug 1943439 - Part 3: Update manage privacy dialog ui

This change is meant to avoid the case where the dialog is opened after changing preferencies and the switches are animated to their default positions as if they have been clicked. It happenes because the store is initiazlied with hardcoded default values, which are immidiately updated from by repository. And if they are different, composable are drawn twice, with the default store values and with updated values.

This patch aims to clean up data flow by simplifying repository interactions. The code as it is has some unwated side effects: init action triggers telemetry updates, and changing in settings triggers telemetry twice. The simpliest solution that I can think of is introduction of separate update and toggle actions, one for data change, the other for the user interaction, so that we only trigger telemetry on the user interaction.

It's a draft without documentation and tests, wanted to get early feedback.

Attachment #9462112 - Attachment is obsolete: true
Attachment #9462714 - Attachment is obsolete: true
Pushed by mavduevskiy@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ad33e4c82423 Part 1: Update tos onboarding page r=android-reviewers,twhite https://hg.mozilla.org/integration/autoland/rev/136705688505 Part 2: Add styling parameter to switch label composable r=android-reviewers,twhite https://hg.mozilla.org/integration/autoland/rev/2fb4e198ee3e Part 3: Update manage privacy dialog ui r=android-reviewers,twhite
Flags: needinfo?(towhite)
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: