194349 - WSDL generated getter params not marked as [out] params in the generated typelib

Status: RESOLVED FIXED

(Core :: XML, defect)

Description

[Johnny Stenback (:jst)]

The WSDL code is crashing and not functioning properly due to the WSDL code not
properly marking the return param of getters as [out] params, in stead they're
incorrectly treated as [in] params. Turns out the code to do this was already
there, but it wasn't being called because of broken type flag checks. When
looking at this we (Harish and myself) found a few other similar problems in the
code and fixed those too. Patch coming up.

Comment 1

[Johnny Stenback (:jst)]

Attachment: Wrong diff, see the next one.

Comment 2

[Johnny Stenback (:jst)]

Comment on attachment 115124 [details] [diff] [review]
Wrong diff, see the next one.

jband, your name is all over this code, care to have a look at these trivial
changes?

Comment 3

[Johnny Stenback (:jst)]

Attachment: Fix bit checking in type flags...

Comment 4

[John Bandhauer]

Comment on attachment 115166 [details] [diff] [review]
Fix bit checking in type flags...

I'm obviously a moron. r=jband	FWIW

Comment 5

[Johnny Stenback (:jst)]

Attachment: Fix *type* checking...

Ok, so while the previous diff did fix something that was wrong, it didn't
really fix what it attempted to fix. There was more to this problem than we
initially thought...

The code was checking if the TD_DOMSTRING (and friends) bit was set in
pparamDesc->flags, but there are two problems with that, the type is not in
pparamDesc->flags, it's in pparamDesc->type, and the TD_DOMSTRING isn't just a
bit, it's an enum that's just a number, so we must *compare* the whole value
(after masking out other bits) to TD_DOMSTRING (et al), not check for bits
being set or not. This patch makes at least integer and float properties
gettable, and also string properties (which didn't work with the previous
patch).

Sorry for requesting reviews on something that wasn't quite what we wanted...

Comment 6

[John Bandhauer]

Comment on attachment 115199 [details] [diff] [review]
Fix *type* checking...

OK, so I screwed this up even worse than you thought :)

>-// particles that are themselvesmodeulgroups (by recurring into 
>+// particles that are themselves modeulgroups (by recurring into 

If you're going to fix comments then fix the spelling of "modeulgroups" too.

r=jband.

Comment 7

[Johnny Stenback (:jst)]

Heh. Yeah, I saw that typo too, but not in time to include it in the patch.
Thanks for having a look.

Comment 8

[Johnny Stenback (:jst)]

Taking. I'll check this in...

Comment 9

[Johnny Stenback (:jst)]

Fix (including the fix for the typo in the comment) checked in. FIXED.