Open
Bug 1943657
Opened 15 days ago
Updated 1 day ago
Keep closed message appears on opt-in UI empty state after turning off RC
Categories
(Firefox :: Shopping, defect, P2)
Firefox
Shopping
Tracking
()
NEW
People
(Reporter: kpatenio, Assigned: rking)
References
(Blocks 1 open bug)
Details
(Whiteboard: [fidefe-RCSidebar])
Attachments
(1 file)
87.95 KB,
image/png
|
Details |
STR:
- For the sake of testing, set these prefs:
- browser.shopping.experience2023.showKeepSidebarClosedMessage = true
- browser.shopping.experience2023.survey.pdpVisits = 5
- browser.shopping.experience2023.autoOpen.enabled = true
- browser.shopping.experience2023.autoOpen.userEnabled = true
- On a PDP, close RC using the X icon
- The "keep closed" message should appear in RC
- Instead of interacting with the message, go to the settings card and press the "turn off" button
Expected:
- The "keep closed" message disappears when the empty state is rendered
Actual:
- The "keep closed" message remains when the empty state is rendered
Notes:
- We render the message as a litelement template in our shopping-container: https://searchfox.org/mozilla-central/rev/f41e8cacb8e8ce254204e2526e98d49d024f1674/browser/components/shopping/content/shopping-container.mjs#599-612. Currently, we rely on a
showingKeepClosedMessage
, and we do not actually check the value of theshowKeepSidebarClosedMessage
pref again after opt-out. - I'm curious if we can pass in
showingKeepClosedMessage: false
when we detect the optIn state change and try to clear content. The reset function passes in several props to the shopping-container.
Severity: -- → S3
Points: --- → 3
Priority: -- → P2
Whiteboard: [fidefe-RCSidebar]
Updated•14 days ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•