1944344 - The Tab Group Callout 1 is displayed for pinned tabs

Status: RESOLVED FIXED

(Firefox :: Messaging System, defect)

Description

[Rares Doghi, Desktop QA]

Attachment: CalloutPined.mp4

Found in

• 136.0a1 (2025-01-28)

Affected versions

• 136.0a1 (2025-01-28)

Affected platforms

• all

Steps to reproduce

1. Have at least 8 tabs open.
2. Pin 2 tabs.
3. From one of the Pinned tabs Use Ctrl + Shift + Left mouse click to open a link in a new tab
4. Close the Opened tab from the X Close button.

Expected result

• The Tab group Callout 1 should be displayed on the next Free Tab.

Actual result

• The Tab group Callout 1 will be displayed directly at the Pinned tab from which the closed Tab originated from.

Regression range
Not a regression

Comment 1

[Dão Gottwald [:dao]]

Hey Emily, could we anchor on the middle of the tab strip if the selected tab is pinned? Thanks!

Comment 2

[Emily McMinn :emcminn]

That should be possible! I can add the change to the open patch and mark this duplicate :)

Comment 3

[Emily McMinn :emcminn]

Hi Rares! This should be fixed by bug 1944103 - could you verify that the callout is now being anchored to the tab strip instead of the active tab when the active tab is pinned?

Comment 4

[Rares Doghi, Desktop QA]

Attachment: 2025-02-04_10h48_12.png

This issue still occurs in our latest Nightly build 137.0a1 (2025-02-03)

Comment 5

[Rares Doghi, Desktop QA]

Well actually heres what happens, when I close the Tab I created from the Pinned tab with the middle mouse, I click on it to make it Active and then I close it, after closing it, the Pinned Tab becomes Active and the Callout shows up for that pinned tab. This happened before as well.

I did get the Callout to show up in the middle of the Vertical Tab strip once but I have no idea how it happened.

Comment 6

[Emily McMinn :emcminn]

Attachment: Bug 1944344 - Anchor vertical callout to tab strip if active tab is pinned

Comment 7

[Emily McMinn :emcminn]

Found it, the fix was only being applied to the horizontal version of the callout. The callout would also have been anchored to the middle of the tab strip if the tab strip was in overflow, so that would possibly be when you saw it before!

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b10e61377ade
Anchor vertical callout to tab strip if active tab is pinned r=omc-reviewers,dao,mviar

Comment 9

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/b10e61377ade

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:emcminn, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox136 to wontfix.

For more information, please visit BugBot documentation.

Comment 11

[Donal Meehan [:dmeehan]]

Limited to nightly only so does not need a beta uplift

Comment 12

[Rares Doghi, Desktop QA]

Attachment: CalloutforPIn.mp4

This issue still occurs in our latest Nightly 137.0a1 (2025-02-10). @Emily can you take a look at this ? should this show up in the middle of the Vertical tab strip ? Also please note that with Vertical Tabs the Find your Open Groups Callout is not displayed where it should be, I will attach a screenshot of it as well

Comment 13

[Rares Doghi, Desktop QA]

Attachment: FindyourTabGroups.png

Find your tab groups callout is misplaced.

Comment 14

[Emily McMinn :emcminn]

Hi Rares, I'll try and repro the pinning bug again! Can I ask what platform you're seeing it on? (i.e. Mac or Windows?)

The "Find your tab groups" callout has changed now, and is anchored to the address bar for both vertical and horizontal tabs. The wording now refers to the address bar instead of the tab overflow/alltabs button, so the callout in the screenshot is appearing as intended.

Here's the Figma for the "Find your tab groups" callout.

EDIT: Hi @rares! I wasn't able to repro the vertical tabs issue and just realized in the mp4 above you were testing using the Experimenter recipe - these are no longer the current messages! The messages have landed in Nightly along with Tab Groups and you shouldn't need to enroll in anything to see them - just have a clean profile, open 8+ tabs, and then close one :) I've removed the unused recipe from preview to help clear things up!