1944412 - Suggest assert method to use in message for no-comparison-or-assignment-inside-ok

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, task)

Description

[Julian Descottes [:jdescottes]]

The linter rule no-comparison-or-assignment-inside-ok could include the suggested assertion method in the message directly.

I don't always remember the various assert helpers we have. Even though the fix can replace the code correctly, it would be nice to have the information in the linter message.

Eg:

Use dedicated assertion methods rather than ok(a > b).

could be

Use dedicated assertion methods (Assert.greater) rather than ok(a > b).

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1944412 - Add assert method in lint message for no-comparison-or-assignment-inside-ok

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5c72f0dd4424
Add assert method in lint message for no-comparison-or-assignment-inside-ok r=Standard8,frontend-codestyle-reviewers,Gijs

Comment 3

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/5c72f0dd4424